Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #26 #64

Merged
merged 3 commits into from Jun 29, 2017

Conversation

Projects
None yet
2 participants
@jcsoo
Copy link
Contributor

jcsoo commented Jun 29, 2017

No description provided.

jcsoo added some commits Jun 29, 2017

@BurntSushi
Copy link
Owner

BurntSushi left a comment

This is awesome, thanks so much! I have one little style nit but otherwise this is good to go. :-)

src/lib.rs Outdated
@@ -315,6 +315,54 @@ impl WalkDir {
/// When `yes` is `true`, the iterator yields the contents of a directory
/// before yielding the directory itself. This is useful when, e.g. you
/// want to recursively delete a directory.
///
/// Assume the following directory tree:

This comment has been minimized.

@BurntSushi

BurntSushi Jun 29, 2017

Owner

Could you add an # Example heading just above this?

@BurntSushi BurntSushi merged commit 4e4c9c4 into BurntSushi:master Jun 29, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@BurntSushi

This comment has been minimized.

Copy link
Owner

BurntSushi commented Jun 29, 2017

Yay thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.