New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct errors in WalkDir type docs #74

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
3 participants
@alisha17
Contributor

alisha17 commented Jul 9, 2017

Fix to #32

@KodrAus

This comment has been minimized.

Show comment
Hide comment
@KodrAus

KodrAus Jul 12, 2017

Contributor

Thanks @alisha17! Do you mind turning those references to contents_first and sort_by into links to the relevant item in the documentation?

Otherwise this looks good to me.

Contributor

KodrAus commented Jul 12, 2017

Thanks @alisha17! Do you mind turning those references to contents_first and sort_by into links to the relevant item in the documentation?

Otherwise this looks good to me.

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Jul 15, 2017

Owner

@alisha17 If you add links to contents_first and sort_by, then I think this can get merged! Thank you!

Owner

BurntSushi commented Jul 15, 2017

@alisha17 If you add links to contents_first and sort_by, then I think this can get merged! Thank you!

@BurntSushi BurntSushi merged commit 3cc8e9e into BurntSushi:master Jul 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment