Skip to content

/walkdir

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

towards 2.0 #85

Merged
merged 10 commits into from Oct 21, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@BurntSushi
@BurntSushi
Copy link
Owner

BurntSushi commented Oct 21, 2017

This PR contains a smattering of commits that should bring walkdir up to 2.0. Most commits are just polishing, but also:

  1. The DirEntryExt trait wasn't actually exported. That's done now.
  2. I optimized the symbolic link checking loop in an attempt to fix this ripgrep bug. It's not related to 2.0, but I was in the code and it was an easy enough change.
  3. Upgrade to use same-file 1.0, which was just released.

BurntSushi added some commits Oct 21, 2017

@BurntSushi
examples: upgrade to docopt 0.8
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
fa866a2
@BurntSushi
symlink: rename symbolic_link to symlink 
Fixes #80
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
8c14235
@BurntSushi
ci: bump to Rust 1.17
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
4acfa6c
@BurntSushi
formatting: misc and wrap to 80 cols
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
0f6dfaf
@BurntSushi
unix: actually export DirEntryExt
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
c8684d8
@BurntSushi
doc: touchups
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
c400292
@BurntSushi
style: switch from try! to ?
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
049c150
@BurntSushi
symlinks: optimize check loop on Windows 
Broadly speaking, this commit is an attempt to fix this issue:
BurntSushi/ripgrep#633

It was reported that symlink checking was taking a long amount of time,
and that one possible way to fix this was to reduce number of times a
file descriptor is opened. In this commit, we amortize opening file
descriptors by keeping a file handle open for each ancestor in the
directory tree. We also open a handle for the candidate file path at
most once, instead of once every iteration.

Note that we only perform this optimization on Windows, where opening a
file handle seems inordinately expensive. In particular, this now causes
us to potentially open more file descriptors than the limit set by the
user, which only happens when following symbolic links. We document this
behavior.
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
5bcc5b8
@BurntSushi
deps: upgrade to same-file 1.0
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
36ff016
@BurntSushi
doc: bump version number to 2
Verified
This commit was signed with a verified signature.
@BurntSushi BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44 Learn about signing commits
Loading status checks…
74d1a22

@BurntSushi BurntSushi merged commit 99fe056 into master Oct 21, 2017
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BurntSushi BurntSushi deleted the ag/towards-2.0 branch Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.