Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Fixed block sync channel closing go routine when closed #159

Merged
merged 2 commits into from Aug 1, 2022

Conversation

icellan
Copy link
Member

@icellan icellan commented Aug 1, 2022

No description provided.

@icellan icellan requested a review from mrz1836 as a code owner August 1, 2022 17:32
@mergify mergify bot assigned mrz1836 Aug 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #159 (3de68ce) into master (27c264c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   52.50%   52.47%   -0.03%     
==========================================
  Files          87       87              
  Lines        9697     9701       +4     
==========================================
  Hits         5091     5091              
- Misses       4198     4202       +4     
  Partials      408      408              
Flag Coverage Δ
unittests 52.47% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
monitor_event_handler.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c264c...3de68ce. Read the comment docs.

@mrz1836 mrz1836 added the hot-fix Urgent or important fix/patch label Aug 1, 2022
Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 07672e4 into master Aug 1, 2022
@mergify mergify bot deleted the siggi/monitor-block-sync-channel-fix branch August 1, 2022 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hot-fix Urgent or important fix/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants