From 24e1e2cc3345e6891ec12c821b425ebc91f41d8d Mon Sep 17 00:00:00 2001
From: Sebastian Thiel <sthiel@thoughtworks.com>
Date: Fri, 7 Jun 2019 08:06:56 +0530
Subject: [PATCH] refactor

---
 src/interactive/widgets/mark.rs | 32 ++++++++++++++------------------
 1 file changed, 14 insertions(+), 18 deletions(-)

diff --git a/src/interactive/widgets/mark.rs b/src/interactive/widgets/mark.rs
index be18d0e5..9ce6ed0c 100644
--- a/src/interactive/widgets/mark.rs
+++ b/src/interactive/widgets/mark.rs
@@ -2,6 +2,7 @@ use crate::interactive::{widgets::COLOR_MARKED_LIGHT, CursorDirection};
 use dua::traverse::{Tree, TreeIndex};
 use dua::{path_of, ByteFormat};
 use itertools::Itertools;
+use std::collections::btree_map::Entry;
 use std::{borrow::Borrow, collections::BTreeMap, path::PathBuf};
 use termion::{event::Key, event::Key::*};
 use tui::{
@@ -27,6 +28,7 @@ pub struct MarkPane {
     marked: EntryMarkMap,
     list: List,
     has_focus: bool,
+    last_sorting_index: usize,
 }
 
 pub struct MarkPaneProps {
@@ -48,28 +50,22 @@ impl MarkPane {
         }
     }
     pub fn toggle_index(mut self, index: TreeIndex, tree: &Tree) -> Option<Self> {
-        // TODO: use HashMapEntry (Vacant/Occupied)
-        if self.marked.get(&index).is_some() {
-            self.marked.remove(&index);
-        } else {
-            if let Some(e) = tree.node_weight(index) {
-                let sorting_index = self
-                    .marked
-                    .values()
-                    .map(|v| v.index)
-                    .max()
-                    .unwrap_or(0)
-                    .wrapping_add(1);
-                self.marked.insert(
-                    index,
-                    EntryMark {
+        match self.marked.entry(index) {
+            Entry::Vacant(entry) => {
+                if let Some(e) = tree.node_weight(index) {
+                    let sorting_index = self.last_sorting_index + 1;
+                    self.last_sorting_index = sorting_index;
+                    entry.insert(EntryMark {
                         size: e.size,
                         path: path_of(tree, index),
                         index: sorting_index,
-                    },
-                );
+                    });
+                }
             }
-        }
+            Entry::Occupied(entry) => {
+                entry.remove();
+            }
+        };
         if self.marked.is_empty() {
             None
         } else {