Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails on 32-bit targets #197

Closed
cinerea0 opened this issue Dec 11, 2023 · 1 comment · Fixed by #198
Closed

Test fails on 32-bit targets #197

cinerea0 opened this issue Dec 11, 2023 · 1 comment · Fixed by #198
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@cinerea0
Copy link
Contributor

When running tests on an i686 target, the following failure occurs:

---- traverse::tests::size_of_entry_data stdout ----
thread 'traverse::tests::size_of_entry_data' panicked at src/traverse.rs:315:9:
assertion `left == right` failed: the size of this should not change unexpectedly as it affects overall memory consumption
  left: 56
 right: 80
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This failure can be seen in CI here.

Reading the assertion message, is it necessary that the size of the data be exactly 80, or just that it be less than or equal to 80?

@Byron Byron added bug Something isn't working help wanted Extra attention is needed labels Dec 11, 2023
@Byron
Copy link
Owner

Byron commented Dec 11, 2023

Indeed, the structure shouldn't get larger without confirmation, but it can always get smaller :).
A fix would definitely be welcome!

cinerea0 added a commit to cinerea0/dua-cli that referenced this issue Dec 11, 2023
EntryData doesn't need to be exactly 80 to test memory consumption, just
less than it.
Byron added a commit that referenced this issue Dec 11, 2023
fix: EntryData size test passes on 32-bit (#197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants