Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with blockquote #6

Closed
dylanowen opened this issue Nov 23, 2019 · 0 comments
Closed

Issues with blockquote #6

dylanowen opened this issue Nov 23, 2019 · 0 comments

Comments

@dylanowen
Copy link
Contributor

@dylanowen dylanowen commented Nov 23, 2019

I've noticed a few scenarios where blockquotes don't render as they were parsed.
https://spec.commonmark.org/0.29/#example-212
creates the events

Start(BlockQuote)
Start(Paragraph)
Text(Borrowed("foo"))
End(Paragraph)
End(BlockQuote)
Start(BlockQuote)
Start(Paragraph)
Text(Borrowed("bar"))
End(Paragraph)
End(BlockQuote)

which renders as

 > foo
 > 
 > bar

when it should be something like

> foo

> bar

Another scenario is
https://spec.commonmark.org/0.29/#example-221
creates the events

Start(BlockQuote)
Start(BlockQuote)
Start(BlockQuote)
Start(Paragraph)
Text(Borrowed("foo"))
SoftBreak
Text(Borrowed("bar"))
SoftBreak
Text(Borrowed("baz"))
End(Paragraph)
End(BlockQuote)
End(BlockQuote)
End(BlockQuote)

which renders as

 >  >  >  >  >  > foo\n >  >  > bar\n >  >  > baz

when it should be something like

 >  >  > foo\n >  >  > bar\n >  >  > baz

I have some test scenarios under my branch here: dylanowen@2dd8024

Byron-TW added a commit that referenced this issue Dec 2, 2019
Better support for blockquotes (#6)
@dylanowen dylanowen closed this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.