Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upBetter support for blockquotes #7
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
Absolutely awesome work, thanks so much for your contribution! |
This comment has been minimized.
This comment has been minimized.
|
v1.2.4 was published to crates.io, containing the fix. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the quick review and publish! |
dylanowen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dylanowen commentedDec 1, 2019
This is my initial attempt at fixing #6 . It makes some changes in the way we serialize blockquotes, so I opted to do most of my testing by verifying that the pulldown-cmark events line up before and after serializing.
Example differences
is now serialized as
this makes it easier to cover the edge case of an empty blockquote, without needing to preserve blockquote state across the events.