Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for blockquotes #7

Merged
merged 3 commits into from Dec 2, 2019
Merged

Conversation

@dylanowen
Copy link
Contributor

dylanowen commented Dec 1, 2019

This is my initial attempt at fixing #6 . It makes some changes in the way we serialize blockquotes, so I opted to do most of my testing by verifying that the pulldown-cmark events line up before and after serializing.

Example differences

> blockquote

is now serialized as

> 
> blockquote

this makes it easier to cover the edge case of an empty blockquote, without needing to preserve blockquote state across the events.

@Byron-TW Byron-TW merged commit fee9004 into Byron:master Dec 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Byron-TW

This comment has been minimized.

Copy link
Collaborator

Byron-TW commented Dec 2, 2019

Absolutely awesome work, thanks so much for your contribution!

@Byron-TW

This comment has been minimized.

Copy link
Collaborator

Byron-TW commented Dec 2, 2019

v1.2.4 was published to crates.io, containing the fix.

@dylanowen dylanowen deleted the dylanowen:blockquotes branch Dec 2, 2019
@dylanowen

This comment has been minimized.

Copy link
Contributor Author

dylanowen commented Dec 2, 2019

Thanks for the quick review and publish!

@dylanowen dylanowen changed the title Better support for blockquotes (#6) Better support for blockquotes Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.