From 84ecdf6ed18b15d68b4ed3e2bfec7eb41b438ad8 Mon Sep 17 00:00:00 2001 From: Michael Fox Date: Mon, 22 Jun 2020 11:46:37 -0400 Subject: [PATCH] fix(parsing): Pass errors through callbacks Don't make assumptions that users want the file stream destroyed when an error is encountered --- packages/parse/src/CsvParserStream.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/parse/src/CsvParserStream.ts b/packages/parse/src/CsvParserStream.ts index 2e38c0f9..4e6ba5ad 100644 --- a/packages/parse/src/CsvParserStream.ts +++ b/packages/parse/src/CsvParserStream.ts @@ -82,7 +82,7 @@ export class CsvParserStream extends Transform { const rows = this.parse(newLine, true); return this.processRows(rows, done); } catch (e) { - return this.destroy(e); + return done(e); } } @@ -114,7 +114,7 @@ export class CsvParserStream extends Transform { const iterate = (i: number): void => { const callNext = (err?: Error): void => { if (err) { - return this.destroy(err); + return cb(err); } if (i % 100 === 0) { // incase the transform are sync insert a next tick to prevent stack overflow