Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`CURRENT_T_EXTRACT_SUBTYPE`. #841

Merged
merged 4 commits into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@dkorolev
Copy link
Member

dkorolev commented Mar 7, 2019

Hi @grixa, CC @mzhurovich,

Grixa, here's CURRENT_T_EXTRACT_SUBTYPE, to use in nontrivial cases of CURRENT_STRUCT_T-s.

In this PR, I've also research on another question you've asked offline -- the using SUPER::SUPER one. The TL;DR is that the CURRENT_CONSTRUCTOR macros have the SFINAE to disable them in various structure compilation modes. So, the easiest solution, I'm afraid, is to duplicate the declaration of CURRENT_CONSTRUCTOR(...), and then use ... : SUPER(...) in its initialization list.

Would appreciate it if you could test the code on Windows as well.

Thanks,
Dima

@dkorolev dkorolev requested a review from grixa Mar 7, 2019

@grixa

This comment has been minimized.

Copy link
Member

grixa commented Mar 7, 2019

Checked compilation on Windows, see 8a69136
CURRENT_EXTRACT_T_SUBTYPE is amazing, thanks!

BTW, VS doesn't like that gtest uses std::tr1 namespace. May be it's time to update it to a newer version.

@grixa

grixa approved these changes Mar 7, 2019

Copy link
Member

grixa left a comment

++LGTM!

@dkorolev

This comment has been minimized.

Copy link
Member

dkorolev commented on 8a69136 Mar 8, 2019

👍

@dkorolev dkorolev merged commit 3f03485 into C5T:stable Mar 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dkorolev

This comment has been minimized.

Copy link
Member Author

dkorolev commented Mar 8, 2019

@grixa -- upgraded googletest in #843, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.