Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`RoundDoubleToString` to support negative numbers and an unary plus. #851

Merged
merged 3 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@dkorolev
Copy link
Member

commented May 9, 2019

No description provided.

@dkorolev dkorolev requested a review from mzhurovich May 9, 2019

@dkorolev

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

@mzhurovich, I'll merge it into stable, because something closed-source needs it. Thx in advance && pls post-review.

@dkorolev dkorolev merged commit c52d6c6 into C5T:stable May 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
}

if (value < 1e-16) {
return "0";

This comment has been minimized.

Copy link
@mzhurovich

mzhurovich May 18, 2019

Member

@dkorolev Does it make sense to return +0 in case of plus_sign = true?

This comment has been minimized.

Copy link
@dkorolev

dkorolev May 19, 2019

Author Member

Good idea. Shall we wait until if and when it becomes important? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.