Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
As @reuteran discussed with you during the Hackathon, we want to extend BGPstream to support RPKI Prefix Origin Validation. The first step is validation of live data. Before we submit a PR, we want to clarify two questions.
To store the ROA payload for validated prefixes, we need a data structure that contains all origin ASNs and prefixes of the covering ROAs.
My current solution consists of two
My question is if you prefer this solution or if I should extend an existing data structure (which?)?
The current output of BGP Elem Format should be extended to show ROA data. My proposal
What do you think?
We've had a chat about how best to integrate this into BGPStream and I have a few comments.
In this model, annotation providers would be optional both at compile time (and disabled by default if they depend on external libraries), and at run time (disabled unless explicitly enabled before the stream starts).
If anyone has any comments/suggestions about this model, we'd love to hear them.
As another comment, please carefully consider the names of your data structures. Currently you have
Lastly, you asked about the elem output format. I think for now your proposed format is fine. We may consider revising it depending on the exact details of how the annotation framework is implemented.