Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybgpstream fields parsing error for large AS path field #82

Closed
digizeph opened this Issue Feb 13, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@digizeph
Copy link
Contributor

digizeph commented Feb 13, 2019

pybgpstream segfaults when extracting elements for updates with very large AS path field (larger than 4096 characters). The issue is caused by an assumption made in AS path field parsing that the AS path field would not be larger than 4k characters.

@digizeph digizeph changed the title pybgpstream fields parsing error when AS path field is very long pybgpstream fields parsing error for large AS path field Feb 13, 2019

@digizeph

This comment has been minimized.

Copy link
Contributor Author

digizeph commented Feb 13, 2019

This issue is addressed in #81 where the program will dynamically allocate larger memory if necessary when the AS path field is very large.
#81 also fixed a number of issues in AS path parsing that allows the program to write \0 to the locations outside the buffer.

@digizeph digizeph referenced this issue Feb 13, 2019

Merged

AS path fixes #81

@digizeph digizeph closed this Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.