AS path fixes #81
Merged
AS path fixes #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some corner cases when passing a buffer too short to fit the full AS path where we tried to write past the end of the buffer.
Previously an AS path with more than ~400 hops would cause a crash when trying create an AS path string. This adds dynamic memory allocation as a fall back in such cases.
digizeph
approved these changes
Feb 13, 2019
|
This PR addresses the issue #82 (more details in the comments there), and other potential memory exceptions during the parse of AS path field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@digizeph i think these fixes justify a new minor (v1.2.2) release