Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed and replaced date topic from diary record #1159

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ColdEvul
Copy link

commented Jun 11, 2019

When merged this pull request will:

  • Removed date topic from the diary records (New function from indev)
  • Added localized topic using pre existing localization strings.

20190611211002_2

Show resolved Hide resolved addons/help/XEH_postInit.sqf Outdated
Show resolved Hide resolved addons/help/XEH_postInit.sqf Outdated
Show resolved Hide resolved addons/help/XEH_postInit.sqf Outdated
@commy2

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

How to turn a draft into a pull request?

Does this error with current release?

@commy2 commy2 added the Enhancement label Jun 12, 2019

@commy2 commy2 added this to the Ongoing milestone Jun 12, 2019

@dedmen

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

How to turn a draft into a pull request?

firefox_2019-06-12_09-42-42

@dedmen

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

While at this, people have been asking for a way to hide diary records
https://forums.bohemia.net/forums/topic/223694-remove-diary-records-from-mods-or-others-already-there/?tab=comments#comment-3361406
Maybe add a setting or variable to disable creation of it?

@commy2 commy2 marked this pull request as ready for review Jun 12, 2019

@ColdEvul

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

Will make the adjustments digested above
and while at it; I can make a setting to disable the records as well for this pull request.

Does this error with current release?

Higly likely; don't know to be honest. Was also the reason why I made a draft of it.

@commy2

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

digested

Suggested? Please don't eat the pull request.

@ColdEvul

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

haha phone autocorrect, yes suggested.

@ColdEvul

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

image

@ColdEvul ColdEvul force-pushed the ColdEvul:NoDatedDiaryRecord branch from 02bc113 to 120f466 Jun 12, 2019

@ColdEvul ColdEvul force-pushed the ColdEvul:NoDatedDiaryRecord branch from 120f466 to ae72280 Jun 12, 2019

@ColdEvul

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

Setting is local.

@ColdEvul

This comment has been minimized.

Copy link
Author

commented Jun 13, 2019

All done ready for review.

I am unsure if the setting handeling is a good solution. But the postInit did not handle anything else so no point running the rest.

@commy2

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Not a fan of making a setting for this. It seems to me that the overhead of a setting, even though small, is not worth such a minor thing as some briefing entries.
The guy on the BIF even said that they had (and lost) a solution in the past that did just mission stuff to hide the diary entries. I would prefer if we just rediscover that solution and put it on the wiki.

@ColdEvul

This comment has been minimized.

Copy link
Author

commented Jun 13, 2019

Well I also removed all diaries once as well in a super hacky way but also lost that solution.

Tho there will be 2 new commands that allow scripts to remove diary records (removeDiarySubject, removeDiaryRecord). I stated this on the forum post as well.

Also unsure of the settings execution. But think it's neat to have the option to hide them.

@commy2

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

That settles it then. I'll doc it on the wiki. Setting not needed.

@ColdEvul

This comment has been minimized.

Copy link
Author

commented Jun 14, 2019

Settings reverted

NOTE: This will cause error if used on version <1.95
New script parameter: createDiaryRecord

@commy2

commy2 approved these changes Jun 14, 2019

Copy link
Contributor

left a comment

Don't merge before updated syntax of createDiaryRecord is in Arma stable.

@commy2

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

Remove will be:

player removeDiarySubject "cba_help_docs";

or:

player removeDiaryRecord ["cba_help_docs", localize "STR_CBA_Help_Keys"];
player removeDiaryRecord ["cba_help_docs", localize "STR_CBA_Credits"];
player removeDiaryRecord ["cba_help_docs", localize "STR_CBA_Addons"];

in next Arma stable I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.