private keyword #204
Merged
private keyword #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect with pushBack
| if (!IS_ARRAY(_this)) exitWith {nil}; | ||
| if (_this isEqualTo []) exitWith {nil}; | ||
|
|
||
| params ["_min"]; | ||
| _index = 0; | ||
|
|
||
| private _index = 0; | ||
|
|
||
| { | ||
| if (isNil "_x" || {(typeName _x) != (typeName 0)}) exitWith {_max = nil; _index = nil;}; |
There was a problem hiding this comment.
Noticed a bug here: _max should be _min here (and in the last isNil check in the file aswell)
There was a problem hiding this comment.
The function doesn't work at all, because a few lines below it does:
if (isNil "_max") exitWith {nil};
with _max never being defined (or carried over from another function due to missing private)
fixed in: #207
There was a problem hiding this comment.
Yep, that's what I referred to with "and in the last isNil check in the file aswell". Good to see the separate PR with the fix. I'll review them ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires 1.54 and #203