Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entities returning duplicates #578

Merged
merged 1 commit into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@PabstMirror
Copy link
Contributor

commented Jan 17, 2017

Fix #567

@commy2
Not sure if there is a better way to do this.
arrayIntersect is expensive on very large arrays, but addClassEH is probably only going to be called at init.

@commy2 commy2 added the Bug Fix label Jan 18, 2017

@commy2 commy2 added this to the 3.2 milestone Jan 18, 2017

@commy2

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2017

arrayIntersect is fine once on addClassEventHandler. We are doing this in the release version already with entities + allUnits, so it's still an improvement over all after the update.

@commy2 commy2 merged commit 9b824dc into master Jan 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@commy2 commy2 deleted the fixEntities branch Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.