New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uniqueUnitItems typo and add assignedItems switch #922

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
3 participants
@dedmen
Contributor

dedmen commented May 12, 2018

Not a critical bug. Just causes the function to return more items that advertised. Which given it's intended use case doesn't matter much.

  • Add's switch to disable assignedItems because these half a dozen items matter for some users

Do you prefer to keep the useless semicolons that I removed?

@commy2 commy2 added this to the 3.7.1 milestone May 13, 2018

@commy2

commy2 approved these changes May 13, 2018

@commy2 commy2 merged commit b1fb981 into CBATeam:master May 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -10,6 +10,7 @@ Parameters:
_backpack - Include items in backpack (Default: true)
_vest - Include items in vest (Default: true)
_uniform - Include items in uniform (Default: true)
_assignedItems - Include assigned items (Default: true)

This comment has been minimized.

@jonpas

jonpas May 17, 2018

Member

What happened to alignment here?

This comment has been minimized.

@commy2

This comment has been minimized.

@dedmen

dedmen May 18, 2018

Contributor

Dedmen just copy pasted a entry from above and changed the names. Dunno why I didn't see that
(╯°□°)╯︵ ┻━┻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment