Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[CEA-708] Missing the last subtitle with "Premature end of file" #646
Sometimes we have incomplete ts parts because of cropped .ts files, for example:
After work we must flush subtitles in current window:
^ This subtitles are written to the file
^ These subtitles have written in CEA-608 file with correct timing, but have not in CEA-708 file.
The second file USA.p8.svc01.srt is incorrect
and error originates from here:
from what I see below this line is we are using 188 as hardcoded value for size of remaining data packet as per standard/recommendation defined in ISO 13818:1 , and some of the following functions depend on it , like
so here we can use dynamic size if possible , I have no idea abt that , but if that is right approach I can move in that direction.
No, this has nothing to do with packet size, that's always 188. It's about the command to display the last subtitle frame not being there (since the stream is incomplete). What we need is a way to dump the contents of the 708 decoder once we reach the end of the stream.…
On Wed, Nov 7, 2018, 02:09 Udit Sanghi ***@***.*** wrote: So, basically we need to add a parameter like --croppedts which when called replaces all 188 to 168. Am I right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#646 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFrJ2Qep-5YuCOJ5z5-YwQcuJki6O_x6ks5usrFfgaJpZM4LjrYs> .