New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Added --noempty parameter #1041

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@MakarovGCI2018
Contributor

MakarovGCI2018 commented Nov 22, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}

@cfsmp3

This comment has been minimized.

Contributor

cfsmp3 commented Nov 22, 2018

This is a huge PR that is reverting back many changes. It should be sent against the current master.

@cfsmp3 cfsmp3 closed this Nov 22, 2018

@ccextractor-bot

This comment has been minimized.

Collaborator

ccextractor-bot commented Nov 22, 2018

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 81/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Collaborator

ccextractor-bot commented Nov 22, 2018

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 3/13
DVB 3/7
DVR-MS 0/2
General 21/27
Hauppage 3/3
MP4 0/3
NoCC 2/10
Teletext 20/21
WTV 0/13
XDS 32/34
CEA-708 12/14
DVD 0/3
Options 73/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment