New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Added support for non-Latin characters in stdout #1056

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@navimakarov
Copy link
Contributor

navimakarov commented Dec 14, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

I found out that ccextractor didn't display non-Latin characters in stdout. There were problems displaying input files with russian letters, subtitles which contain non-Latin symbols (with -stdout parameter) and so on. Fixed this problem.

  • Strange symbols in Input filename before changes
    beforechanges

  • Fixed non-Latin letters
    afterchanges

navimakarov added some commits Dec 14, 2018

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Dec 14, 2018

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 81/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@cfsmp3 cfsmp3 merged commit 74eefae into CCExtractor:master Dec 14, 2018

1 of 3 checks passed

CI - linux Not all tests completed successfully, please check
Details
CI - windows Tests queued
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Dec 14, 2018

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 32/34
CEA-708 14/14
DVD 3/3
Options 83/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

ShouryaAggarwal pushed a commit to ShouryaAggarwal/ccextractor that referenced this pull request Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment