Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Change initialization of Tesseract and fix segfault in hardsubx. #1083

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
3 participants
@thelastpolaris
Copy link
Contributor

thelastpolaris commented Mar 25, 2019

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Changed the way Tesseract is initialized in hardsubx to be the same as in ocr.c. Fixed the problem with incorrect pass of pointer to av_frame_free function, which caused segfault.

Improve the way Tesseract is initialized in hardsubx. Fix segfault du…
…ring the cleaning the frame data in hardsubx.

@cfsmp3 cfsmp3 merged commit 116f308 into CCExtractor:master Mar 25, 2019

1 of 3 checks passed

CI - linux Running tests
Details
CI - windows Tests queued
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Mar 25, 2019

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 83/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Mar 26, 2019

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:

  • ccextractor -datapid 5603 -autoprogram -out=srt -latin1 -teletext 85c7fc1ad7...
  • ccextractor -autoprogram -out=srt -latin1 85271be4d2...
  • ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66...
  • ccextractor -stdout -quiet -nofc -nodvbcolor 79a51f3500...
  • ccextractor -stdout -quiet -nofc -nodvbcolor 767b546f96...

Check the result page for more info.

@thelastpolaris thelastpolaris referenced this pull request Apr 12, 2019

Open

[BUG] Not enough memory to initialize Tesseract #1008

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.