Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Update badge with total download count #1088

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
3 participants
@aadibajpai
Copy link
Contributor

commented May 22, 2019

And link to latest release. Earlier it was for a specific release instead of the cumulative download count spanning all releases.

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor.
  • I am an active contributor to CCExtractor.

Update badge with total download count
And link to latest release

@aadibajpai aadibajpai changed the title **[IMPROVEMENT]** Update badge with total download count [IMPROVEMENT] Update badge with total download count May 22, 2019

@canihavesomecoffee canihavesomecoffee merged commit 5133729 into CCExtractor:master May 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aadibajpai aadibajpai deleted the aadibajpai:patch-3 branch May 22, 2019

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 81/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 3/7
DVR-MS 0/2
General 2/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Teletext 0/21
WTV 0/13
XDS 0/34
CEA-708 0/14
DVD 0/3
Options 0/86

All tests were passed completely.


Check the result page for more info.
@aadibajpai

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 3/7
DVR-MS 0/2
General 2/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Teletext 0/21
WTV 0/13
XDS 0/34
CEA-708 0/14
DVD 0/3
Options 0/86
All tests were passed completely.

Check the result page for more info.

very fast 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.