Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove webvtt styling when not using webvtt-full #1092

Merged
merged 9 commits into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@rayfoss
Copy link
Contributor

commented Jun 5, 2019

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

addresses #1076

leaves behind the null terminator bug, but it hasn't been an issue with anything except gedit as of yet.

rayfoss added some commits Jun 5, 2019

move x-timestamp-map up to abide by specifications
and support ffmpeg and brightcove
remove stray new line, crlfs are added upstream
297 seems to contain a null bug

@rayfoss rayfoss changed the title [FIX] Rayfoss webvtt styling [FIX] remove webvtt styling when not using webvtt-full Jun 5, 2019

@rayfoss rayfoss changed the title [FIX] remove webvtt styling when not using webvtt-full [FIX] Remove webvtt styling when not using webvtt-full Jun 5, 2019

rayfoss added some commits Jun 5, 2019

@rayfoss

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@cfsmp3

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

On a quick visual inspection it seems like webvtt_create_css and use_webvtt_styling are mutually exclusive. If yes, why do we need 2 variables?

@saurabhshri can you check this out? (the PR otherwise seems OK to me)

@rayfoss

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Create css outputs a separate file with the styles

@cfsmp3 cfsmp3 merged commit 4035814 into CCExtractor:master Jun 5, 2019

1 of 3 checks passed

CI - linux Tests queued
Details
CI - windows Tests queued
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.