Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**[FIX]** Enable RPM creation to work correctly #1106

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@djotaku
Copy link
Contributor

commented Sep 10, 2019

In raising this pull request, I confirm the following (please check boxes):

  • [x ] I have read and understood the contributors guide.
  • [ x] I have checked that another pull request for this purpose does not exist.
  • [x ] I have considered, and confirmed that this submission will be valuable to others.
  • [x ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x ] I give this submission freely, and claim no ownership to its content.
  • [x ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • [x ] I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}

@djotaku

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

This would fix: #1064

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 5/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 32/34
CEA-708 14/14
DVD 3/3
Options 79/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@djotaku

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

is this PR bot thing right? I changed a file in the linux folder and it says Windows things broke? Or are they broken on the master branch already?

@canihavesomecoffee

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Hi Eric,

In this specific case you can indeed ignore these. We still have a couple of cases that always tend to fail :(

About the two broken tests on Linux, I would have to double check, but I suspect that they are also broken (they shouldn't be though) on master.

@cfsmp3 can merge it anyhow if it looks ok for him.

@cfsmp3 cfsmp3 merged commit 8a9d924 into CCExtractor:master Sep 12, 2019

2 of 4 checks passed

CI - linux Not all tests completed successfully, please check
Details
CI - windows Not all tests completed successfully, please check
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.