Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Make COMPILATION.md Easier To Use #1110

Merged

Conversation

@thealphadollar
Copy link
Contributor

commented Sep 28, 2019

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

  • Improve the structure of package installation command to make it easy to copy and paste
  • Improve the formatting of code blocks by mentioning language as specified by MD
- Improve the structure of package installation command to make it easy to copy and paste
- Improve the formatting of code blocks by mentioning language as specified by MD
@thealphadollar thealphadollar force-pushed the thealphadollar:improve_contributionmd branch from d526b38 to 3020fd2 Sep 28, 2019
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 28, 2019

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 5/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 28, 2019

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 32/34
CEA-708 14/14
DVD 3/3
Options 79/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@thealphadollar

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2019

@cfsmp3 Any updates on this?

@canihavesomecoffee canihavesomecoffee merged commit bdfe4ca into CCExtractor:master Oct 19, 2019
2 of 4 checks passed
2 of 4 checks passed
CI - linux Not all tests completed successfully, please check
Details
CI - windows Not all tests completed successfully, please check
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.