Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed X-TIMESTAMP-MAP formatting error #1126

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@prs-prabodh
Copy link
Contributor

prs-prabodh commented Nov 22, 2019

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fixed the X-TIMESTAMP-MAP formatting error. Made required changes as mentioned in the issue #1125

@prs-prabodh prs-prabodh changed the title Fixed X-TIMESTAMP-MAP formatting error [FIX] Fixed X-TIMESTAMP-MAP formatting error Nov 22, 2019
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Nov 22, 2019

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Nov 22, 2019

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 32/34
CEA-708 14/14
DVD 3/3
Options 83/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@cfsmp3

This comment has been minimized.

Copy link
Contributor

cfsmp3 commented Nov 23, 2019

This PR reformats all the source. It should just contain the specific one-liner fix.

@cfsmp3 cfsmp3 merged commit 280b430 into CCExtractor:master Nov 26, 2019
2 of 4 checks passed
2 of 4 checks passed
CI - linux Not all tests completed successfully, please check
Details
CI - windows Copy code to local folder
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.