Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Added the option to disable timestamps for WebVTT #1176

Merged
merged 5 commits into from Jan 13, 2020

Conversation

@dhrumilp15
Copy link
Contributor

dhrumilp15 commented Jan 12, 2020

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

In response to issue #1127, this fix adds an option to remove the X-TIMESTAMP-MAP header for WebVTT.

@NilsIrl

This comment has been minimized.

Copy link
Contributor

NilsIrl commented Jan 12, 2020

The problem isn't that we want to remove X-TIMESTAMP-MAP. It's that X-TIMESTAMP-MAP isn't always present.

@dhrumilp15

This comment has been minimized.

Copy link
Contributor Author

dhrumilp15 commented Jan 12, 2020

Now you've confused me - I thought issue #1127 asked for an option to enable / disable the X-TIMESTAMP-MAP header for WebVTT.

@NilsIrl

This comment has been minimized.

Copy link
Contributor

NilsIrl commented Jan 12, 2020

Yes, that's what it originally asked for. But this assumed X-TIMESTAMP-MAP is always present.

@NilsIrl

This comment has been minimized.

Copy link
Contributor

NilsIrl commented Jan 12, 2020

If you read the comments on the issue it make clear things up (or make them even worse 😂 )

@dhrumilp15

This comment has been minimized.

Copy link
Contributor Author

dhrumilp15 commented Jan 12, 2020

I've been reading the comments on the issue for several days now and I am just as confused now as I was before I had read the comments

@NilsIrl

This comment has been minimized.

Copy link
Contributor

NilsIrl commented Jan 12, 2020

Well keep, your PR as it is and just make so that in the case where we want timestamps, they are actually shown.

The thing is that there isn't a reason why one wouldn't want to have X-TIMESTAMP-MAP.

@dhrumilp15

This comment has been minimized.

Copy link
Contributor Author

dhrumilp15 commented Jan 12, 2020

My PR doesn't disable the header, it's just adding the option for the --no-timestamp-map flag to disable the X-TIMESTAMP-MAP header. Also, doesn't the X-TIMESTAMP-MAP header only apply to WebVTT?

@NilsIrl

This comment has been minimized.

Copy link
Contributor

NilsIrl commented Jan 12, 2020

doesn't the X-TIMESTAMP-MAP header only apply to WebVTT

yes

@NilsIrl

This comment has been minimized.

Copy link
Contributor

NilsIrl commented Jan 12, 2020

#1137 fixes the problem

I didn't find it good so it was closed

@dhrumilp15

This comment has been minimized.

Copy link
Contributor Author

dhrumilp15 commented Jan 12, 2020

DVB and WebVTT are separate formats, so why would the X-TIMESTAMP-MAP header be in DVB? This is regarding your fix to the issue's thread

@NilsIrl

This comment has been minimized.

Copy link
Contributor

NilsIrl commented Jan 12, 2020

DVB is a video format

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Jan 12, 2020

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Jan 12, 2020

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
src/lib_ccx/ccx_encoders_webvtt.c Outdated Show resolved Hide resolved
dhrumilp15 added 2 commits Jan 13, 2020
@cfsmp3 cfsmp3 merged commit 79f18b9 into CCExtractor:master Jan 13, 2020
2 of 4 checks passed
2 of 4 checks passed
CI - linux Tests queued
Details
CI - windows Tests queued
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NilsIrl NilsIrl mentioned this pull request Jan 13, 2020
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.