Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Comment out issue #1178

Open
wants to merge 4 commits into
base: master
from

Conversation

@NilsIrl
Copy link
Contributor

NilsIrl commented Jan 13, 2020

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

This was discussed already.

This fixes the problem where issues have the instructions in them which can decrease readability.

@cfsmp3

This comment has been minimized.

Copy link
Contributor

cfsmp3 commented Jan 13, 2020

This requires some debate :-) Personally I would start with

Please read this and then delete all lines above the ---CUT HERE--- here:
(then, explanations about stuff, and finally that CUT HERE line)

And finally the CCExtractor version, links to files, and error description.

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Jan 13, 2020

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 32/34
CEA-708 14/14
DVD 3/3
Options 80/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@NilsIrl

This comment has been minimized.

Copy link
Contributor Author

NilsIrl commented Jan 13, 2020

So you would rather have no comment at all? And make it clear that the text has to be removed

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Jan 15, 2020

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@cfsmp3

This comment has been minimized.

Copy link
Contributor

cfsmp3 commented Jan 18, 2020

So you would rather have no comment at all? And make it clear that the text has to be removed

Correct. Issues need to meet 3 requirements IMHO

  • Be exhaustive
  • Include everything we need (i.e. samples) to reproduce
  • Include the basic information on top, so no boilerplate stuff that makes all issues look identical at first glance.
@NilsIrl NilsIrl force-pushed the NilsIrl:comment_out_issue branch from 7ba4e7d to ef553b0 Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.