Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[IMPROVEMENT] Remove freep warning #1180
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Hold on, this must be completely breaking things - if you don't pass a pointer to the pointer you want to free then you can't change the pointer value from inside freep() which is the whole point of it in the first place!
That's going to fail if you pass "hello" instead of "&hello", because freep() won't be able to change the value of the outside variable.
[ EDIT: I see you're actually replacing free() with a #define , that could actually work ]
I've merged your stuff. I don't want to cast to void * in 30 places.…
On Mon, Jan 13, 2020 at 11:54 AM Nils ANDRÉ-CHANG ***@***.***> wrote: Or we could pass a void * to freep and then cast in there. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1180?email_source=notifications&email_token=ABNMTWO5DZ5AB3IRY25BORLQ5TBIPA5CNFSM4KGHZ542YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI2CAVY#issuecomment-573841495>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNMTWIGCWYCS5JBFIQQGUTQ5TBIPANCNFSM4KGHZ54Q> .
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).
Your PR breaks these cases:
Check the result page for more info.