Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Clang format #1222

Merged
merged 3 commits into from Jan 30, 2020
Merged

[IMPROVEMENT] Clang format #1222

merged 3 commits into from Jan 30, 2020

Conversation

@NilsIrl
Copy link
Contributor

NilsIrl commented Jan 30, 2020

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I am an active contributor to CCExtractor.


#1219 (comment)

requires #1219

@cfsmp3 cfsmp3 requested a review from canihavesomecoffee Jan 30, 2020
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Jan 30, 2020

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 15/21
WTV 12/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 82/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@canihavesomecoffee

This comment has been minimized.

Copy link
Member

canihavesomecoffee commented Jan 30, 2020

@NilsIrl Can you rebase your branch against our current master to minimize the diff? :)

@NilsIrl NilsIrl force-pushed the NilsIrl:clang-format2 branch from 002551f to b52da47 Jan 30, 2020
@NilsIrl

This comment has been minimized.

Copy link
Contributor Author

NilsIrl commented Jan 30, 2020

@NilsIrl Can you rebase your branch against our current master to minimize the diff? :)

Done

@canihavesomecoffee

This comment has been minimized.

Copy link
Member

canihavesomecoffee commented Jan 30, 2020

@cfsmp3 Are you fine with the clang formatting rules?

For me the action itself (aside from the name) looks fine.

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Jan 30, 2020

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 12/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
Co-Authored-By: Willem <github@canihavesome.coffee>
@cfsmp3 cfsmp3 merged commit 722d524 into CCExtractor:master Jan 30, 2020
2 of 5 checks passed
2 of 5 checks passed
format format
Details
CI - linux Running tests
Details
CI - windows Tests queued
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NilsIrl NilsIrl deleted the NilsIrl:clang-format2 branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.