Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 Compatibility #281

Closed
thealphadollar opened this issue Jun 3, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@thealphadollar
Copy link
Contributor

commented Jun 3, 2019

Please prefix your issue with one of the following: [BUG], [PROPOSAL], [QUESTION].

Sample platform commit (found at the bottom of each page) : X.X.X

In raising this issue, I confirm the following (please check boxes, eg [X]):

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and in opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

My familiarity with the project is as follows (check one, eg [X]):

  • I have never visited/used the platform.
  • I have used the platform just a couple of times.
  • I have used the platform extensively, but have not contributed previously.
  • I am an active contributor to the platform.

The issue involves delivering:

  • typings for all appropriate functions. Reference
  • Integration of mypy with unit-tests. Reference

@thealphadollar thealphadollar self-assigned this Jun 3, 2019

thealphadollar added a commit to thealphadollar/sample-platform that referenced this issue Jun 5, 2019

@thealphadollar thealphadollar referenced this issue Jun 5, 2019

Merged

[IMPROVEMENT] Add Multiple Checks #296

6 of 9 tasks complete

canihavesomecoffee added a commit that referenced this issue Jun 5, 2019

[IMPROVEMENT] Add Multiple Checks (#296)
* fixes #272

* add isort, update sort orders, add isort to travis

* fix mod_sample/controllers.py, add dodgy test for keys

* update readme

* add mypy, add mypy testing, implement adhoc solution to errors, concerns #281

* update readme, add mypy to travis

* allow travis failing on 3.4 because mypy isn't supported

@thealphadollar thealphadollar referenced this issue Jul 1, 2019

Merged

Add Annotations To All Modules #310

6 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.