Skip to content
Permalink
Browse files

Added fixes for proposal Pitch max limit and deletion of proposal fin…

…al url error, and proposal promotion error
  • Loading branch information...
carlosbpf committed Nov 4, 2019
1 parent df9b757 commit 76d0e500f6305f7c5635685d1a9a9b030d140663
@@ -81,9 +81,9 @@
List<Long> contestTypeIds, List<Long> contestTierIds, Boolean visible,
Long contestPhaseId,
Integer ribbon) {
return listProposals(start, limit, filterText, Collections.singletonList(contestId),
return listProposals(start, limit, filterText, (contestId==null)?(null):(Collections.singletonList(contestId)),
contestTierIds, contestTypeIds, null, null, visible, contestPhaseId,
Collections.singletonList(ribbon), null, null);
(ribbon==null)?(null):(Collections.singletonList(ribbon)), null, null);
}

default List<ProposalWrapper> getProposalsInPublicContests(List<Long> contestTypeIds,
@@ -64,9 +64,8 @@ public void deleteProposal(HttpServletRequest request, Model model, HttpServletR
proposalContext.getClients().getProposalClient().updateProposal(proposal);

AlertMessage.success("Proposal was deleted successfully!").flash(request);
response.sendRedirect(
proposal.getProposalLinkUrl(contest, contestPhase.getId())
+ "/tab/ADMIN");

response.sendRedirect(contest.getContestLinkUrl());
} else {
throw new ProposalsAuthorizationException("User isn't allowed to delete proposal ");
}
@@ -47,7 +47,7 @@ public boolean isValid(Object value, ConstraintValidatorContext context) {
context.disableDefaultConstraintViolation();
Long contestTypeId = ConfigurationAttributeKey.DEFAULT_CONTEST_TYPE_ID.get();
String proposalPitchName = ContestTypeAttributeKey.PROPOSALS_PITCH_NAME.get(contestTypeId);

String message = resourceMessageResolver.getLocalizedMessage("contests.proposal.sections.pitch.validation",
proposalPitchName, maxPitchLength);
ConstraintValidatorContext.ConstraintViolationBuilder violationBuilder =

0 comments on commit 76d0e50

Please sign in to comment.
You can’t perform that action at this time.