Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Add Python 3 to the build matrix. #968

Merged
merged 2 commits into from
Mar 6, 2018
Merged

Conversation

zenhack
Copy link
Contributor

@zenhack zenhack commented Mar 5, 2018

There is predicatbly a failure, but I suspect it's something actually related to Python 3 now, so I'm submitting this as a pr.

Relates to: #700

...as allowed to fail, per the discussion in CCI-MOC#700
This should be good enough for our purposes, and it's in the trusty
repos by default. I believe 3.6 is not; IIRC some of my other projects
(e.g. [simp_le][1]) have had to do special things to get it in travis.

[1]: https://github.com/zenhack/simp_le
@coveralls
Copy link

coveralls commented Mar 5, 2018

Pull Request Test Coverage Report for Build 1685

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.338%

Totals Coverage Status
Change from base Build 1681: 0.0%
Covered Lines: 2097
Relevant Lines: 3534

💛 - Coveralls

@xuhang57
Copy link
Contributor

xuhang57 commented Mar 5, 2018

I might not know what I am talking about. But fwiw, normally, python 3 is using pip3 rather than pip2 to manage packages so does that mean we need to update that in travis for our python 3 build?

@naved001
Copy link
Contributor

naved001 commented Mar 5, 2018

Didn't make a difference when I was using pip3 vs pip for installing in my python3 virtualenv. it just couldn't import importlib._bootstrap in both cases (the current failure in our travis build).

@naved001
Copy link
Contributor

naved001 commented Mar 5, 2018

Also, in a virtualenv with python3 as default, pip seems to refer to pip3.

(.venv) naved:~/hil/.venv/bin$ python --version
Python 3.5.2
(.venv) naved:~/hil/.venv/bin$ pip --version
pip 9.0.1 from /home/naved/hil/.venv/lib/python3.5/site-packages (python 3.5)
(.venv) naved:~/hil/.venv/bin$ pip3 --version
pip 9.0.1 from /home/naved/hil/.venv/lib/python3.5/site-packages (python 3.5)
(.venv) naved:~/hil/.venv/bin$ pip2 --version
pip 9.0.1 from /usr/local/lib/python2.7/dist-packages (python 2.7)

@xuhang57
Copy link
Contributor

xuhang57 commented Mar 5, 2018

Is there a way to let travis to show all builds on this page?

- "3.4"
matrix:
allow_failures:
- python: "3.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you are using 3.4 because 3.6 is failing. But since 3.4 is failing as well, should we just use 3.6?

@xuhang57
Copy link
Contributor

xuhang57 commented Mar 5, 2018

https://devguide.python.org/#status-of-python-branches

Given what it says in the official guide, we should start with 3.6 since 3.4 will be deprecated even before 2.7

@zenhack
Copy link
Contributor Author

zenhack commented Mar 5, 2018 via email

@xuhang57
Copy link
Contributor

xuhang57 commented Mar 5, 2018

@zenhack Thanks for explaining it. Should we install python 3.6 in the Travis container then?

My point is more like, instead of supporting 3.4 now, which it will be deprecated before 2020, we should look into 3.6 which we don't have to bother ourselves to do a version bump later since we are just about to set thing ups. Admittedly, I am not against using 3.4

@zenhack
Copy link
Contributor Author

zenhack commented Mar 5, 2018 via email

@xuhang57
Copy link
Contributor

xuhang57 commented Mar 6, 2018

I suggest we could merge this and close the issue #700 . Maybe open a new issue that is about supporting python 3. Or we could just keep using the old issue.

Thanks Ian!

Copy link
Contributor

@xuhang57 xuhang57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naved001 naved001 merged commit a4b9760 into CCI-MOC:master Mar 6, 2018
@zenhack zenhack deleted the python3 branch July 27, 2018 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants