Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Comments from @DANAJK :
Variable output_path might be confusingly named as it appears to be both a path and part of the filename.
Ahead of the code review in two days, I thought it would be useful to give a summary of the class hierarchy of this PR. I'll also circulate an email with the doxygen.
There is an abstract base class,
With aladin, you can also get the forward and backwards transformation matrices. With f3d, you can set the initial transformation, as well as floating and reference time points.
Nifti images are tricky because their data is stored as
There are 5 classes for images:
This is an abstract base class. It has the virtual void method
To do the weighted mean of a series of images, set the input images with
Set the input with
There is a simple parser for supplying the parameter files for the NiftyReg registrations. Classes include
C-wrapper, Matlab, Python
I won't get into that here, but so far all methods that exist in C++ are also in Python and Matlab.
As @KrisThielemans says, best not to get bogged down in wrapping. Just for interest, here's the output from
The first row encompasses both the C++ code and the C-interface to Python and Matlab, which when separated out look like this:
ashgillman left a comment
A number of smallish comments.
I think the main things are just:
Following the code review today, the following changes have been suggested: