New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taylor diagrams from GUI (plot set 14) #1180

Open
mcenerney1 opened this Issue Mar 27, 2015 · 21 comments

Comments

Projects
None yet
6 participants
@mcenerney1
Contributor

mcenerney1 commented Mar 27, 2015

From AMWG diagnostics in the gui I get the following error

Traceback (most recent call last):
File "/usr/local/uvcdat/03_25_15/vistrails/vistrails/gui/uvcdat/diagnosticsDockWidget.py", line 660, in buttonClicked
self.applyClicked()
File "/usr/local/uvcdat/03_25_15/vistrails/vistrails/gui/uvcdat/diagnosticsDockWidget.py", line 777, in applyClicked
self.displayCell(res30, row, col)
File "/usr/local/uvcdat/03_25_15/vistrails/vistrails/gui/uvcdat/diagnosticsDockWidget.py", line 856, in displayCell
G = V[Gtype]
KeyError: 'Taylor'

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Mar 27, 2015

what version of UV-CDAT you are using?

@mcenerney1

This comment has been minimized.

Contributor

mcenerney1 commented Mar 27, 2015

The latest; built on 3/25

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Mar 27, 2015

just from a default check point of view, can you review your .uvcdat folder? It should be in your home directory.

  • Aashish
@mcenerney1

This comment has been minimized.

Contributor

mcenerney1 commented Mar 27, 2015

What would I be looking for?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Mar 27, 2015

sorry remove (and not review)

remove .uvcdat folder

@mcenerney1

This comment has been minimized.

Contributor

mcenerney1 commented Mar 27, 2015

No change

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Mar 28, 2015

It is a bug then. I have added the labels. We will try to fix it asap.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Mar 28, 2015

@painter1 @isubsmith any ideas?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 29, 2015

Probably expects "taylor" lower case but it's just a wild guess

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 29, 2015

Also this does not belong here this is uvcmetrics code in visyrails code.... please report where appropriate...

@isubsmith

This comment has been minimized.

isubsmith commented Mar 30, 2015

No idea, but I think Charles' guess is likely along the right path.

I suspect V['Taylor'] in this context doesn't exist. Someone probably needs to find out what types exist for a projectController.plot_manager._plot_list["VCS"] and adjust accordingly.

     pm = projectController.plot_manager
     V=pm._plot_list["VCS"]
     gm = res30.presentation
     from packages.uvcdat_cdms.init import get_canvas, get_gm_attributes, original_gm_attributes
     from gui.uvcdat.uvcdatCommons import gmInfos
     Gtype = res30.type
     G = V[Gtype]  <- barfs
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 30, 2015

very close from having a solution

@durack1

This comment has been minimized.

Member

durack1 commented Sep 24, 2015

@aashish24 @doutriaux1 should this be a 2.4 milestone? I think it's a very strong candidate..

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 25, 2015

@durack1 agreed. @doutriaux1 are you looking into this?

@mcenerney1

This comment has been minimized.

Contributor

mcenerney1 commented Sep 25, 2015

No it should not be considered for 2.4.This issue has not been looked at for several months. At the time noone was calling for this capability and it was pushed down in priority. It is folly to drop everything else to get this operational for this release. It should be considered for the next release.

@durack1

This comment has been minimized.

Member

durack1 commented Sep 25, 2015

@mcenerney1 was the issue that taylor diagrams (and the functionality to create them) was no longer working? If so this is a high priority, as the taylor diagram functionality is a big deal for scientists using vcs

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 28, 2015

I would say let's not try to fix it here and let's have @chaosphere2112 revisit it with the new GUI.

@durack1

This comment has been minimized.

Member

durack1 commented Sep 30, 2015

@doutriaux1 @aashish24 I just noted that this bug was noted as critical in the v2.2.0 release notes so might warrant fixing if it's possible in the 2.4.0 timeline?

@doutriaux1 doutriaux1 added this to the 3.0 milestone Sep 30, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 30, 2015

it's GUI related, the taylordiagrams work from command line as far as I know. I'm pretty sure it's not going to be touched for 2.4 and @chaosphere2112 touched up GUI revisit will take care of this.

@durack1

This comment has been minimized.

Member

durack1 commented Sep 30, 2015

@doutriaux1 might be a good idea to rename this issue then - I'm uncertain what it is, but from the current title thought it indicated that taylor diagrams are currently not working

@doutriaux1 doutriaux1 changed the title from Taylor diagrams (plot set 14) to Taylor diagrams from GUI (plot set 14) Sep 30, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 30, 2015

@chaosphere2112 assigned this to you, just so that we make sure it works in the next GUI.

@doutriaux1 doutriaux1 added Medium Priority and removed Critical labels Sep 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment