New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isoline labels text color broken #1230

Closed
doutriaux1 opened this Issue Apr 22, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Apr 22, 2015

text colors seem to be messed up if you look at the test baselines: https://raw.githubusercontent.com/UV-CDAT/uvcdat-testdata/master/baselines/vcs/test_isoline_labels.png or https://github.com/UV-CDAT/uvcdat-testdata/blob/master/baselines/vcs/test_vcs_isoline_labels_multi_label_input_types.png

If you look at the pngs carefully you will realize that the text colors change for isolines of same values (look at 50 or 80 for example in the second png) this is wrong, all isolines of the same value should have the same color.

Also I think the code will need more tweaks beacuse right now we are using the same "lut" for both isolines and textcolors but it is conceivable that the user ask for different colors (isolines in shades of blue, but text in shades of red for readibilty)

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Apr 23, 2015

I have local fix, just need to update the unit tests on the VTK side of things. Will push soon.

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Apr 23, 2015

VTK merge request in at https://gitlab.kitware.com/vtk/vtk/merge_requests/144. I'll cherry-pick this onto our VTK head in a moment.

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Apr 23, 2015

Should be fixed by #1203.

See also CDAT/uvcdat-testdata#36 and CDAT/VTK#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment