New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vcs3d failing test #1305

Closed
aashish24 opened this Issue May 11, 2015 · 10 comments

Comments

Projects
None yet
7 participants
@aashish24
Contributor

aashish24 commented May 11, 2015

No description provided.

@aashish24 aashish24 added the DV3D label May 11, 2015

@aashish24 aashish24 added this to the 2.2 milestone May 11, 2015

@durack1

This comment has been minimized.

Member

durack1 commented May 11, 2015

@aashish24 if this is the same issue as https://open.cdash.org/testDetails.php?test=334149793&build=3808629 - it's DVD3D not VCS3D that's got the problem.

It looks to me like it's a case of continental bounds missing a single point, so the start not returning to the exact end point, closing the polygon.

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented May 11, 2015

Agreed -- shouldn't the DV3D team be looking at this?

@ThomasMaxwell

This comment has been minimized.

Contributor

ThomasMaxwell commented May 11, 2015

The code that generates the boundaries is in shapeFileReader.getPolyLines in Packages/DV3D/Shapefile.py.

— Tom

From: "Paul J. Durack" <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Monday, May 11, 2015 at 1:51 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Subject: Re: [uvcdat] Fix vcs3d failing test (#1305)

@aashish24https://github.com/aashish24 if this is the same issue as https://open.cdash.org/testDetails.php?test=334149793&build=3808629 - it's DVD3D not VCS3D that's got the problem.

It looks to me like it's a case of continental bounds missing a single point, so the start not returning to the exact end point, closing the polygon.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1305#issuecomment-100996736.

@durack1 durack1 added the Bug label May 11, 2015

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented May 12, 2015

If I'm reading the file that @ThomasMaxwell pointed at correctly, the continents are defined in a GIS shapefile, which is then rendered using vtkPolyData. I'm guessing it's an OpenGL or VTK quirk, not an issue with DV3D; it works perfectly fine on my mac, so it must be something platform dependent.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented May 12, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 12, 2015

@dlonie @ThomasMaxwell is busy with other tasks and we discussed that vcs3D (visualization related) changes will be taken care by you and me (obviously with @ThomasMaxwell's help).

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 13, 2015

and @chaosphere2112 we also discussed that @aashish24 and @dlonie are very busy and wouldn't want you guys charging your precious time on things we an also fix 😉

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 13, 2015

@doutriaux1 we are never too busy for you 👍

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 13, 2015

Awwww... You're too nice 😉 Anyhow you do run out of money though 😜

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 13, 2015

I think we all do -:)

@doutriaux1 doutriaux1 modified the milestones: 2.3, 2.2 May 26, 2015

@doutriaux1 doutriaux1 closed this Sep 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment