Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels are too close together #1339

Closed
potter2 opened this issue May 21, 2015 · 10 comments
Closed

Labels are too close together #1339

potter2 opened this issue May 21, 2015 · 10 comments
Assignees

Comments

@potter2
Copy link

potter2 commented May 21, 2015

As you can see from the attached the isoline labels are too close together. I understand there is a parameter that can be set, but it needs to be available. For the GUI the default also needs to be father apart.
labels

@alliepiper
Copy link
Contributor

Just to update: I'll add some options on the VTK side of things to adjust the label spacing, and @sankhesh and @doutriaux1 will take a look at adding the necessary methods to VCS to expose the option to users.

@aashish24
Copy link
Contributor

@dlonie can we get it done ASAP? My understanding is that this should be a fairly easy task that does not require much effort.

@alliepiper
Copy link
Contributor

"soon"

Still fighting with memory leaks on the refactor :(

@aashish24
Copy link
Contributor

Would it be possible to pause that for a moment and get this done so that Sankhesh can add an API to VCS? Or may @sankhesh can do this one (assuming that it would be easy)

@alliepiper
Copy link
Contributor

I can get it done later today.

@potter2
Copy link
Author

potter2 commented Jul 7, 2015

David,
When you are doing the labels, could to check to see if they work on an overlay (isoline on top of isofill)?

Thanks,
Jerry

On Jul 7, 2015, at 7:40 AM, David Lonie <notifications@github.commailto:notifications@github.com> wrote:

I can get it done later today.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1339#issuecomment-119224515.

Gerald (Jerry) Potter
NASA Goddard Space Flight Center
E-mail gerald.potter@nasa.govmailto:gerald.potter@nasa.gov
Office 28:S241
Phone 707.315.8314
Analysis and Data Consultant
Department GSFC:606.2

@alliepiper
Copy link
Contributor

@potter2 That's a separate issue (#1338). This issue requires work on the VTK side of things, while that one looks to be an issue with primitive ordering on the VCS side.

@alliepiper
Copy link
Contributor

VTK merge request up: https://gitlab.kitware.com/vtk/vtk/merge_requests/374

After this is accepted into VTK master, I'll cherry pick it onto the UVCDAT VTK fork, and then it will be available to VCS. It defines new methods vtkLabeledContourMapper::[S|G]etSkipDistance that define a minimum distance between labels on the same line.

After that, it's up to @doutriaux1 and @sankhesh to add the VCS specific bits to expose it to UV-CDAT users.

@alliepiper
Copy link
Contributor

Still waiting on the patch to be merged upstream, but I've cherry-picked it to the UVCDAT VTK fork. See my last comment for details on the new API.

sankhesh added a commit that referenced this issue Aug 6, 2015
sankhesh added a commit that referenced this issue Aug 7, 2015
sankhesh added a commit to CDAT/uvcdat-testdata that referenced this issue Aug 7, 2015
@doutriaux1
Copy link
Contributor

@potter2 it's in master please try.

sankhesh added a commit that referenced this issue Sep 3, 2015
sankhesh added a commit that referenced this issue Sep 3, 2015
sankhesh added a commit that referenced this issue Sep 3, 2015
sankhesh added a commit that referenced this issue Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants