New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDMS3DPlot -> CDMSCell connections are invalid #1346

Closed
remram44 opened this Issue May 26, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@remram44
Contributor

remram44 commented May 26, 2015

CDMS3DPlot's 'self' output port has type CDMS3DPlot, but CDMSCell's 'plot' input port has type CDMSPlot.

The connection is built programmatically by the pipeline helper, but it is invalid. A common base CDMSBasePlot should have been introduced (or CDMSPlot renamed to CDMS2DPlot?).

I don't know if we can change this without breaking previously saved workflows, UV-CDAT doesn't use the pipeline upgrades mechanism (and doesn't even version packages).

Everything would be fine if CDMS3DPlot was a subclass of CDMSPlot but it's not.

@remram44 remram44 added the VisTrails label May 26, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 26, 2015

@remram44 at this point I don't think there are many saved workflows. I think it's ok to break it early, before many people have saved workflows, and make it right.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 26, 2015

@remram44 for extreme/desperate cases do you think it would be possible for users to manually edit their workflow to make it work again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment