New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`size` keyword argument has no effect in `vcs.init` #1347

Closed
chaosphere2112 opened this Issue May 26, 2015 · 9 comments

Comments

Projects
None yet
4 participants
@chaosphere2112
Contributor

chaosphere2112 commented May 26, 2015

I'm poking through cleaning up the docstrings in VCS, and I found the size keyword argument on vcs.init. It passes it through to Canvas.Canvas; shouldn't we use that instead of hardcoding in default sizes that look nice on @doutriaux1's monitor (😉)?

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented May 26, 2015

Ah, digging further into the code I see that it should take a string that specifies an existing size. Hm, that's nonintuitive.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 27, 2015

@chaosphere2112 I have a bug report on VTK repo ( @aashish24 @dlonie if you could push to have it fixed) that prevents me from getting the user's desktop size. That would be the right way to fix this "nice for @doutriaux1 screen issue).

@doutriaux1 doutriaux1 added this to the 2.3 milestone May 27, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 27, 2015

@aashish24 @dlonie the issue is/was: http://www.vtk.org/Bug/view.php?id=14882

It is apparently fixed and in master. Is it in "our" uvcdat-master ? Last I tried it didn't work.

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented May 27, 2015

I'll run the tests against a more up-to-date VTK and bump if all goes well.

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented May 27, 2015

There have been a few API changes in VTK master that are affecting VCS. I'll get these ironed out and push a branch when it's ready.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 27, 2015

thanks!

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented May 27, 2015

#1348 should do it. I need someone to manually test it (buildbot won't handle the VTK update) and regenerate the dv3d vector baseline, since that's a buggy test for me on arch linux.

@doutriaux1 doutriaux1 assigned doutriaux1 and unassigned aashish24 Sep 2, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 14, 2015

the size was supposed to be for A4 vs postscript etc... It's more an page_aspect_ratio than anything

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Sep 15, 2015

Yeah, I figured that out after poking it enough. At some point (post-2.4) it would be nice to have an easier way to specify window size, since it's a bit wonky right now.

doutriaux1 added a commit that referenced this issue Sep 22, 2015

VTK let us get screen size again from python
using this feature and reintroducing use to size keyword in vcs.init()
fix #1347

doutriaux1 added a commit that referenced this issue Sep 23, 2015

Merge pull request #1563 from UV-CDAT/issue_1347_use_screensize
Issue 1347 use screen size

Can't wait any longer @aashish24 merging, we really needs this in in order to move forward for the rc.

fix #1347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment