Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs.Canvas.setantialiasing unusable #1400

Closed
allisonvacanti opened this issue Jun 22, 2015 · 4 comments
Closed

vcs.Canvas.setantialiasing unusable #1400

allisonvacanti opened this issue Jun 22, 2015 · 4 comments
Assignees
Labels

Comments

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 22, 2015

vtkRenderWindow needs to have multisampling settings specified before the first render, but currently setantialiasing can only be used before the window is created (which triggers an error) or after initialization (which has no effect).

The easy fix would be to make an antialiasing ivar in the canvas or backend that can be set between calls to vcs.init and Canvas.plot, and warns if called after the window is already initialized.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Jun 23, 2015

@dlonie I would assign it to @sankhesh

@allisonvacanti
Copy link
Contributor Author

@allisonvacanti allisonvacanti commented Jun 23, 2015

@sankhesh Grab me if you want to go over this -- this one should be higher priority than the other issues.

@allisonvacanti
Copy link
Contributor Author

@allisonvacanti allisonvacanti commented Jun 23, 2015

@sankhesh The code of interest is in Packages/vcs/Lib/VTKPlots.py, the setantialiasing and getantialiasing methods.

To visually determine whether or not antialiasing is working the following command line can be used to produce a line plot with aliasing artifacts:

[build dir]/install/bin/runtest [source dir]/testing/vcs/test_vcs_basic_gms.py --gm_type=yxvsx --show

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Jul 16, 2015

Fixed and merged

@sankhesh sankhesh closed this Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants