New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isofill Blank Spots on Solid with Indices/Levels #1645

Closed
chaosphere2112 opened this Issue Oct 28, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@chaosphere2112
Contributor

chaosphere2112 commented Oct 28, 2015

@aashish24 @sankhesh @doutriaux1 Just ran into this one while testing my performance branch, then went back and found it on master.

import vcs, cdms2
x = vcs.init()
f = cdms2.open(vcs.sample_data + "/clt.nc")
s = f("clt")

iso = x.createisofill()
iso.levels = range(0, 100, 10)
iso.fillareaindices = range(1, 11)
iso.ext_2 = True

x.plot(s, iso)

will give you this:

out

Obviously, fillareaindices shouldn't have any effect on a solid isofill, so that's a pretty weird behavior.

@chaosphere2112 chaosphere2112 added the VCS label Oct 28, 2015

@chaosphere2112 chaosphere2112 added this to the 2.4 milestone Oct 28, 2015

@chaosphere2112 chaosphere2112 added the Bug label Oct 28, 2015

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Oct 28, 2015

The ext_2 is insignificant, but was in the script that I used to generate the image.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Oct 28, 2015

Also with patterns:

import vcs, cdms2
x = vcs.init()
f = cdms2.open(vcs.sample_data + "/clt.nc")
s = f("clt")

iso = x.createisofill()
iso.levels = range(0, 110, 10)
iso.fillareastyle = "pattern"
iso.fillareaindices = range(1, 11)
iso.fillareacolors = range(20, 220, 20)
iso.fillareaopacity = [100] * 10

x.plot(s, iso)

pattern_white_tri

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 13, 2015

@danlipsa Could you please look into this next?

@danlipsa danlipsa assigned danlipsa and unassigned sankhesh Nov 16, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 18, 2015

@danlipsa I am hoping this would a tiny bug somewhere. @doutriaux1 we may have to patch our release.

danlipsa added a commit that referenced this issue Nov 19, 2015

BUG #1645: Blank spots on solid fillareastyle with fillareaindices
The solid fillareastyle was treated as a pattern style in that
each level was extracted and rendered individually. Because of a
bug in vtkBandedPolyDataContourFilter lower isocontours differ
from upper isocontours which results in blank spots. In this fix
we trigger merging of levels which fixes the problem for solid fill.
We'll fix the problem for pattern fill in a subsequent commit.

danlipsa added a commit that referenced this issue Nov 19, 2015

BUG #1645: Blank spots on solid fillareastyle with fillareaindices
The solid fillareastyle was treated as a pattern style in that
each level was extracted and rendered individually. Because of a
bug in vtkBandedPolyDataContourFilter lower isocontours differ
from upper isocontours which results in blank spots. In this fix
we trigger merging of levels which fixes the problem for solid fill.
We'll fix the problem for pattern fill in a subsequent commit.

danlipsa added a commit that referenced this issue Nov 19, 2015

BUG #1645: Blank spots on solid fillareastyle with fillareaindices
The solid fillareastyle was treated as a pattern style in that
each level was extracted and rendered individually. Because of a
bug in vtkBandedPolyDataContourFilter lower isocontours differ
from upper isocontours which results in blank spots. In this fix
we trigger merging of levels which fixes the problem for solid fill.
We'll fix the problem for pattern fill in a subsequent commit.

danlipsa added a commit that referenced this issue Nov 19, 2015

BUG #1645: Blank spots on solid fillareastyle with fillareaindices
The solid fillareastyle was treated as a pattern style in that
each level was extracted and rendered individually. Because of a
bug in vtkBandedPolyDataContourFilter lower isocontours differ
from upper isocontours which results in blank spots. In this fix
we trigger merging of levels which fixes the problem for solid fill.
We'll fix the problem for pattern fill in a subsequent commit.
@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Nov 19, 2015

Seems the problem is how vtkBandedPolyDataContourFilter fills a band. Attached are two pictures: first isocontours at 40 and 50 then a band for 40-50. The triangle below the point labeled 53.9 never gets filled.
contours-40-50
contours-filled-40-50

danlipsa added a commit that referenced this issue Nov 20, 2015

BUG #1645: Blank spots on solid fillareastyle with fillareaindices
The solid fillareastyle was treated as a pattern style in that
each level was extracted and rendered individually. Because of a
bug in vtkBandedPolyDataContourFilter this results in blank spots. In this fix
we trigger merging of levels which fixes the problem for solid fill.
We'll fix the problem for pattern fill in a subsequent commit.

danlipsa added a commit that referenced this issue Nov 23, 2015

BUG #1645: Blank spots on solid fillareastyle with fillareaindices
The solid fillareastyle was treated as a pattern style in that
each level was extracted and rendered individually. Because of a
bug in vtkBandedPolyDataContourFilter this results in blank spots. In this fix
we trigger merging of levels which fixes the problem for solid fill.
We'll fix the problem for pattern fill in a subsequent commit.

danlipsa added a commit that referenced this issue Nov 23, 2015

BUG #1645: Blank spots on solid fillareastyle with fillareaindices.
The solid fillareastyle was treated as a pattern style in that
each level was extracted and rendered individually. Because of a
bug in vtkBandedPolyDataContourFilter this results in blank spots. In this fix
we trigger merging of levels which fixes the problem for solid fill.
We'll fix the problem for pattern fill in a subsequent commit.

danlipsa added a commit that referenced this issue Nov 23, 2015

BUG #1645: Blank spots on solid fillareastyle with fillareaindices.
The solid fillareastyle was treated as a pattern style in that
each level was extracted and rendered individually. Because of a
bug in vtkBandedPolyDataContourFilter this results in blank spots. In this fix
we trigger merging of levels which fixes the problem for solid fill.
We'll fix the problem for pattern fill in a subsequent commit.

chaosphere2112 added a commit that referenced this issue Nov 23, 2015

Merge pull request #1700 from UV-CDAT/blank-spots
BUG #1645: Blank spots on solid fillareastyle with fillareaindices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment