New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambert proj appears to be broken?? #1763

Closed
doutriaux1 opened this Issue Jan 6, 2016 · 11 comments

Comments

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Jan 6, 2016

old lambert over north america:

p=x.createprojection()
p.type = "lambert"
b=x.createboxfill()
b.projection=p
x.plot(s(longitude=(-120,-20),latitude=(20,60)),b)

lambert

@doutriaux1 doutriaux1 added the VCS label Jan 6, 2016

@doutriaux1 doutriaux1 added this to the 2.4 milestone Jan 6, 2016

@doutriaux1 doutriaux1 self-assigned this Jan 6, 2016

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 6, 2016

new vcs
lambert_bad

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 6, 2016

@aashish24 @danlipsa if you beat me to it please feel free to fix it.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 6, 2016

test_vcs_lambert
ok making progress it looks like gctp was smarter than proj4 we need to set all parameters manually or it will not work

p.centralmeridian = -80
p.originlatitude=0
p.standardparallel1 = 20
p.standardparallel2=60
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 12, 2016

fixed in 2.4.0 but on macs exposes proj4 issue listed @ #1777

@doutriaux1 doutriaux1 closed this Jan 12, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Jan 13, 2016

@doutriaux1 @aashish24 Do we need to pass +over to the lambert projection (or to polar (non gctp))? What I want to get at, is a test case, where we need to pass +over, it works on most machines but it does not work on certain macs and annie. If we don't have that we'll spend time to fix something that we don't really need. Maybe for these projections, +over does not work consistently because people don't need that so nobody tested for that.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 13, 2016

it's worth trying. I will do that now.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 13, 2016

@danlipsa I don't think that's the issue, looking at the code:

no_over_proj4_parameter_projections = round_projections+["aeqd", "lambert conformal c"]

Then we have a section in vcs2vtk.py that does:

        if projection.type not in no_over_proj4_parameter_projections:
            pd.SetOptionalParameter("over", "true")
        else:
            pd.SetOptionalParameter("over", "false")

So obviously we're not trying over on lambert and it still fails on macs.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 13, 2016

i think the issue could be coming from:

            setProjectionParameters(pd, projection)

because basically it seems like that it is the only thing we took out for poalr non gctp that made it work again, but going into the function I don't think it does anything...

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Jan 14, 2016

@doutriaux1 What is the test that is failing on macs? Is it failing on annie as well?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 14, 2016

only on mac, if you look at CMakeList.txt it is commented out if it's an apple. test_vcs_lambert I believe is the name. I "think" it passes on annie, but it could also be luck 😉

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Jan 14, 2016

Interesting. I tried this test on my mac - which had problems with +over and polar non gctp and it passes. I will create a branch where I activate this test and see where it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment