Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polar plot boxfill cannot be plotted with north pole up #1886

Closed
doutriaux1 opened this issue Mar 21, 2016 · 17 comments
Closed

polar plot boxfill cannot be plotted with north pole up #1886

doutriaux1 opened this issue Mar 21, 2016 · 17 comments
Assignees
Milestone

Comments

@doutriaux1
Copy link
Contributor

gm = x.createboxfill()
x.plot(s(latitude=(90,-90)),gm)
x.plot(s(latitude=(-90,90)),gm)

produces the same plot with souh pole at center

@aashish24
Copy link
Contributor

weird 😢

@doutriaux1
Copy link
Contributor Author

also:

gm.datawc_y2 = -90
gm.datawc_y1 = 90

does not do the job.

@danlipsa
Copy link
Contributor

@doutriaux1 What is the rule here? if y1 < y2 you look from the south pole otherwise you look from the north pole? What if you have latitude [80, 90] do still look from the south pole? Thanks.

@doutriaux1
Copy link
Contributor Author

@danlipsa the rule is the y1 is the center one. so if y1<y2 then south pole centered, if y1>y2 then north pole centered

@doutriaux1
Copy link
Contributor Author

x.plot(s(latitude=(80,90)),b)

80_90

@doutriaux1
Copy link
Contributor Author

x.plot(s(latitude=(90,80)),b)

90_80

@danlipsa
Copy link
Contributor

@doutriaux1 So, you just look at y1. If y1 > 0 it is north pole centered, if y1 < 0 it is south pole centered. Is this the rule? Does this mean that (80, 90) is the same as (90, 80)?

@danlipsa
Copy link
Contributor

@doutriaux1 What if y1 is 0?

@doutriaux1
Copy link
Contributor Author

@danlipsa no I just look at y1 vs y2 see examples above

@danlipsa
Copy link
Contributor

@doutriaux1 Sorry, I don't get the rule. Looking at the examples:
(80, 90) . Looks like the view is from -90. (south pole)

(90, 80). Looks like the view is from 90. (north pole)
So we are back to my original rule: if y1 < y2 you look from the south pole otherwise you look from the north pole?

the rule is the y1 is the center one. so if y1y2 then north pole centered

For (80, 90). 80 is the center one. What does this mean? Is the view form 90 or -90? It seems these are the only possibilities for polar projection.

@doutriaux1
Copy link
Contributor Author

@danlipsa you are right there are only two possibilities North Pole or South Pole Centered.
y1<y2 -> South Pole
y1>y2 -> North Pole

@danlipsa
Copy link
Contributor

@doutriaux1 So we have the following algorithm:
y1 <= y2 -> South Pole
y1 > y2 -> North Pole

@doutriaux1
Copy link
Contributor Author

exactly

@doutriaux1
Copy link
Contributor Author

if y1==y2 we may want to error exit

@danlipsa
Copy link
Contributor

Great. Thanks Charles!

danlipsa added a commit that referenced this issue Apr 1, 2016
Polar projection should use:
South Pole for y1 < y2
North Pole for y1 > y2.
@danlipsa
Copy link
Contributor

danlipsa commented Apr 1, 2016

Fix on:
#1904

danlipsa added a commit that referenced this issue Apr 6, 2016
Polar projection should use:
South Pole for y1 < y2
North Pole for y1 > y2.
danlipsa added a commit that referenced this issue Apr 8, 2016
Polar projection should use:
South Pole for y1 < y2
North Pole for y1 > y2.
danlipsa added a commit that referenced this issue Apr 8, 2016
BUG #1886: Polar projection does not change pole.
@danlipsa
Copy link
Contributor

danlipsa commented Apr 8, 2016

#1904

@danlipsa danlipsa closed this as completed Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants