New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad contouring algorithm #1959

Closed
doutriaux1 opened this Issue May 3, 2016 · 10 comments

Comments

Projects
None yet
4 participants
@doutriaux1
Member

doutriaux1 commented May 3, 2016

using clt data

iso = x.createisoline()
iso.line = ["dot","dash-dot","long-dash"] * 100
x.plot(s/10000.,iso)
x.png("bad_contours")

gives us:

bad_contours

around -55South the dots are not dotted everywhere, but looks like most line are badly drawn everywhere anyway. @lee1043 noticed this.

@doutriaux1 doutriaux1 added this to the 2.6 milestone May 3, 2016

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 16, 2016

@danlipsa any chance you could tackle this one?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented May 16, 2016

Sure, after I am done with streamlines I can take a look

@danlipsa danlipsa added the 1 - Ready label May 16, 2016

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 16, 2016

@doutriaux1 is this something we need asap? What you think of the priority of this task?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 16, 2016

it's holding up @lee1043 work, @lee1043 how badly do you need this? It is definitely needed for 2.6

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 16, 2016

@danlipsa sounds like this is something needed soon. I would fix this one and then do the streamlines.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented May 16, 2016

@aashish24 sounds good.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 16, 2016

Thanks. Yes I think it's more urgent than streamlines (but you know everything is important anyway)

@lee1043

This comment has been minimized.

lee1043 commented May 16, 2016

It would be nice if I can use this in this week. Thanks!

@danlipsa danlipsa added 2 - Working <= 5 and removed 1 - Ready labels May 16, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented May 16, 2016

@doutriaux1 @lee1043 I can see that the lines do not respect the specifications (dot, dash-dot and long-dash). Is that the bug?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 16, 2016

@danlipsa yes more or less, we are not sure if the spaces are not respected or if that there are many short lines started next to each other making it look like one non-dotted/dashed line. Also it seems to be dependent on the actual data values (not 100% sure about that one)

danlipsa added a commit that referenced this issue May 19, 2016

BUG #1959: Fix memory override for vtkContourFiler in isofillpipeline.
This resulted in vtkStripper to generate double coverage of isocountours which resulted in
messed-up patterns.
Also adjusted plot patterns to easier to discriminate.

danlipsa added a commit that referenced this issue May 20, 2016

BUG #1959: Fix memory override for vtkContourFiler in isofillpipeline.
This resulted in vtkStripper to generate double coverage of isocountours which resulted in
messed-up patterns.
Also adjusted plot patterns to easier to discriminate.

danlipsa added a commit that referenced this issue May 23, 2016

BUG #1959: Fix memory override for vtkContourFiler in isofillpipeline.
This resulted in vtkStripper to generate double coverage of isocountours which resulted in
messed-up patterns.
Also adjusted plot patterns to easier to discriminate.

@doutriaux1 doutriaux1 closed this May 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment