New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vt doesn't have all the steps #283

Closed
potter2 opened this Issue Sep 25, 2013 · 34 comments

Comments

Projects
None yet
8 participants
@potter2

potter2 commented Sep 25, 2013

I did a multiple step problem. select variables, recalculate F to C, used climate tools to average axes, I did not get any errors or exceptions. I plotted a number of plots, erased several and plotted more. Then I saved the workflow. I have attached the .vt file to an email to Ben.

@benbu

This comment has been minimized.

Member

benbu commented Sep 26, 2013

@potter2 I never got an email with that attachment.

@potter2

This comment has been minimized.

potter2 commented Sep 26, 2013

@benbu

This comment has been minimized.

Member

benbu commented Sep 26, 2013

It looks like you replied to the github notification, but github doesn't support attachments. You'll have to send it directly to me.

I found a bug when loading a saved vt file, not sure if it's the same problem you're having, but I'm about to push a fix for it.

@benbu

This comment has been minimized.

Member

benbu commented Sep 26, 2013

There was a bug when loading a vt file containing 3+ chain of computed variables. This should be fixed in uvcdat-next. Please update and test it again.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 1, 2013

  • var.var = self.create_exec_new_variable_pipeline(var.name)

This is in the only change I saw? So I guess we were executing the pipeline too soon? I am willing approve and merge.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 1, 2013

@doutriaux1 Have a look at the branch. I merged it into master but didn't delete it.

  • Aashish
@benbu

This comment has been minimized.

Member

benbu commented Oct 1, 2013

Yeah that was the only change, although I haven't heard back from Jerry yet whether or not it fixed his problem.

@potter2

This comment has been minimized.

potter2 commented Oct 2, 2013

I'm in the UK now without my computer. I'll get back to you text week.

Jerry

@williams13

This comment has been minimized.

Contributor

williams13 commented Oct 2, 2013

Okay… No worries… :-)

Best regards,
Dean

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 17, 2014

@potter2 still true probably right? @remram44 can you take a look please?

@doutriaux1 doutriaux1 added this to the 2.1 milestone Oct 17, 2014

@remram44

This comment has been minimized.

Contributor

remram44 commented Oct 17, 2014

@vvpalav please check if this still happens

@remram44 remram44 assigned vvpalav and unassigned remram44 Oct 20, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 10, 2014

@vvpalav any updates on this?

@vvpalav

This comment has been minimized.

vvpalav commented Nov 10, 2014

I haven't started on this yet .. I'll post updates by the end of this week.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 10, 2014

@vvpalav we can probably move this to 2.2 would that be better for you? @williams13 is that ok to move this to 2.2?

@vvpalav

This comment has been minimized.

vvpalav commented Nov 19, 2014

Is this issue moved to 2.2?
If we still targeting this for 2.1, then @potter2, @benbu -- can we please get the file to reproduce this issue. I can quickly check if this is valid or can be closed?

@doutriaux1 doutriaux1 modified the milestones: 2.1, 2.2 Feb 2, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Feb 20, 2015

@potter2 @vvpalav what's the status on this?

@vvpalav

This comment has been minimized.

vvpalav commented Feb 21, 2015

I tried to reproduce but didn't get the error .. @potter2 can you please try and confirm if this still exists.

@vvpalav

This comment has been minimized.

vvpalav commented Feb 27, 2015

@potter2 .. can you please verify this issue .. its has been hanging around for a long time.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Feb 27, 2015

@potter2 use the uvcdat branch Yosemite_rebased to test this on 10.10

cd [sources]
git fetch --all -p
git checkout Yosemite_rebased
cd
mkdir build_Yosemite
cd !$
cmake [sources]
make -j4
@potter2

This comment has been minimized.

potter2 commented Feb 27, 2015

Charles,
Thanks, I’ll try it tomorrow

Jerry

Gerald (Jerry) Potter
NASA Goddard Space Flight Center
E-mail gerald.potter@nasa.govmailto:gerald.potter@nasa.gov
Office 28:S241
Phone 707.315.8314
Analysis and Data Consultant
Department GSFC:606.2

On Feb 27, 2015, at 3:17 PM, Charles Doutriaux <notifications@github.commailto:notifications@github.com> wrote:

@potter2https://github.com/potter2 use the uvcdat branch Yosemite_rebased to test this on 10.10

cd [sources]
git fetch --all -p
git checkout Yosemite_rebased
cd
mkdir build_Yosemite
cd !$
cmake [sources]
make -j4


Reply to this email directly or view it on GitHubhttps://github.com//issues/283#issuecomment-76491047.

@williams13

This comment has been minimized.

Contributor

williams13 commented Feb 28, 2015

If we get everything into master then all we need to do is clone master to test everything.

From: potter2 <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, February 27, 2015 at 3:59 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] .vt doesn't have all the steps (#283)

Charles,
Thanks, I’ll try it tomorrow

Jerry

Gerald (Jerry) Potter
NASA Goddard Space Flight Center
E-mail gerald.potter@nasa.govmailto:gerald.potter@nasa.govmailto:gerald.potter@nasa.gov
Office 28:S241
Phone 707.315.8314
Analysis and Data Consultant
Department GSFC:606.2

On Feb 27, 2015, at 3:17 PM, Charles Doutriaux <notifications@github.commailto:notifications@github.commailto:notifications@github.com> wrote:

@potter2https://github.com/potter2 use the uvcdat branch Yosemite_rebased to test this on 10.10

cd [sources]
git fetch --all -p
git checkout Yosemite_rebased
cd
mkdir build_Yosemite
cd !$
cmake [sources]
make -j4


Reply to this email directly or view it on GitHubhttps://github.com//issues/283#issuecomment-76491047.


Reply to this email directly or view it on GitHubhttps://github.com//issues/283#issuecomment-76495527.

@potter2

This comment has been minimized.

potter2 commented Feb 28, 2015

I will try to build it on 10.10 tomorrow

Sent from my iPhone

On Feb 27, 2015, at 2:15 PM, Vinayak Palav <notifications@github.commailto:notifications@github.com> wrote:

@potter2https://github.com/potter2 .. can you please verify this issue .. its has been hanging around for a long time.


Reply to this email directly or view it on GitHubhttps://github.com//issues/283#issuecomment-76482749.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Feb 28, 2015

yes and no.
1- Sam's branch not quite ready
2- Yosemite branch needs to be tested a bit more on macs and also on non-mac to make sure I didn't break anything.

@vvpalav

This comment has been minimized.

vvpalav commented Mar 2, 2015

@potter2 @doutriaux1 .. Can we close this issue?

@potter2

This comment has been minimized.

potter2 commented Mar 2, 2015

I haven't tested it yet. Should I build it and try it or do you have a 10.10 binary I could try?

@vvpalav

This comment has been minimized.

vvpalav commented Mar 2, 2015

I tried on my ubuntu but didn't really get any error. Maybe exact steps are little different than what I did.
@doutriaux1 .. can you please answer this about 10.10 branch?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 2, 2015

@potter2 I will stick a binary on dropbox for you asap.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 3, 2015

@potter2 I just shared a build with you on dropbox with a 10.10 binary

@potter2

This comment has been minimized.

potter2 commented Mar 3, 2015

Charles,
Thanks, I'll try it on the morning.

Jerry

Sent from my iPad

On Mar 2, 2015, at 10:29 PM, Charles Doutriaux <notifications@github.commailto:notifications@github.com> wrote:

@potter2https://github.com/potter2 I just shared a build with you on dropbox with a 10.10 binary


Reply to this email directly or view it on GitHubhttps://github.com//issues/283#issuecomment-76894053.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 3, 2015

Let me know

@potter2

This comment has been minimized.

potter2 commented Mar 3, 2015

This is fixed

@vvpalav

This comment has been minimized.

vvpalav commented Mar 3, 2015

Thank you @potter2 .. closing this issue.

@vvpalav vvpalav closed this Mar 3, 2015

@potter2

This comment has been minimized.

potter2 commented Mar 3, 2015

Charles,
The .vt file works now. There are quite a few things that are broken
now.. Is the version you sent me close to release?

Jerry

On 3/3/15 6:55 AM, Charles Doutriaux wrote:

Let me know


Reply to this email directly or view it on GitHub
#283 (comment).

Gerald (Jerry) Potter
NASA Goddard Space Flight Center
E-mail gerald.potter@nasa.gov
Office 28:S241
Phone 707.315.8314
Analysis and Data Consultant
Department GSFC:606.2

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 4, 2015

@potter2 yes

@chaosphere2112 chaosphere2112 added the Bug label May 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment