New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDAT_BUILD_MODE=ALL does NOT build ALL #544

Closed
doutriaux1 opened this Issue Aug 8, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@doutriaux1
Member

doutriaux1 commented Aug 8, 2014

ALL mode is on, so why isn't matplotlib built?
or mpi4py? or PIXMAN or PYCLIMATE or PYTABLES?

 CDAT_BUILD_LIBCF                 ON                                                                                                        
 CDAT_BUILD_LIBXML2               ON                                                                                                        
 CDAT_BUILD_LIBXSLT               ON                                                                                                        
 CDAT_BUILD_MARKUPSAFE            ON                                                                                                        
 CDAT_BUILD_MATPLOTLIB            OFF                                                                                                       
 CDAT_BUILD_MODE                  ALL                                                                                                       
 CDAT_BUILD_MPI                   ON                                                                                                        
 CDAT_BUILD_MPI4PY                OFF                                                                                                       
 CDAT_BUILD_MYPROXYCLIENT         ON                                                                                                        
 CDAT_BUILD_NCURSES               ON                                                                                                        
 CDAT_BUILD_NETCDF                ON                                                                                                        
 CDAT_BUILD_NETCDFPLUS            ON                                                                                                        
 CDAT_BUILD_NUMEXPR               ON                                                                                                        
 CDAT_BUILD_NUMPY                 ON                                                                                                        
 CDAT_BUILD_PARALLEL              ON                                                                                                        
 CDAT_BUILD_PARAVIEW              ON                                                                                                        
 CDAT_BUILD_PIP                   ON                                                                                                        
 CDAT_BUILD_PIXMAN                OFF                                                                                                       
 CDAT_BUILD_PKGCONFIG             ON                                                                                                        
 CDAT_BUILD_PNG                   ON                                                                                                        
 CDAT_BUILD_PYCLIMATE             OFF                                                                                                       
 CDAT_BUILD_PYGMENTS              ON                                                                                                        
 CDAT_BUILD_PYLIBXML2             OFF                                                                                                       
 CDAT_BUILD_PYOPENSSL             ON                                                                                                        
 CDAT_BUILD_PYQT                  ON                                                                                                        
 CDAT_BUILD_PYSPHARM              OFF                                                                                                       
 CDAT_BUILD_PYTABLES              OFF                                                                                                       
 CDAT_BUILD_PYZMQ                 ON                                                                                                        
 CDAT_BUILD_R                     OFF                                                                                                       
 CDAT_BUILD_READLINE              ON                                                                                                        
 CDAT_BUILD_SCIENTIFICPYTHON      OFF                                                                                                       
 CDAT_BUILD_SCIKITS               OFF                                                                                                       
 CDAT_BUILD_SCIPY                 ON                                                                                                        
 CDAT_BUILD_SETUPTOOLS            ON                                                                                                        

CDAT_BUILD_MPI:                                                                                                                              
Press [enter] to edit option                                                                                           CMake Version 2.8.12.2
Press [c] to configure
Press [h] for help           Press [q] to quit without generating
Press [t] to toggle advanced mode (Currently Off)

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Aug 8, 2014

@doutriaux1 doutriaux1 added bug labels Aug 8, 2014

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 8, 2014

@doutriaux1 this is not a bug. No package specifies the matplotlib as the dependency. And its not ON by default.

@aashish24 aashish24 assigned doutriaux1 and unassigned jbeezley Aug 8, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 8, 2014

Ok I have to admit your add_dependency think is black magic to me.
If you can explain :
add_cdat_package_dependent(udunits2 "" "" OFF "CDAT_BUILD_LEAN" OFF)

that would help, here's what I "guess"
1- pkg name
2/3 "" : uh.... description strings?
4 OFF: what is OFF
5 some buildmode or other cmake var?
6 OFF : turn it OFF if 5 is ON? or turn it OFF unless 5 is ON?

thx.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 8, 2014

macro(add_cdat_package_dependent package_name version build_message value dependencies default)

  1. pkg name
  2. min version desired
  3. build message
  4. ON or OFF based on the evaluation of the condition in 5)
  5. Condition
  6. Default state.

Hope this helps.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 8, 2014

Thank you @aashish24 I could never figure out the diff between 4 and 6 this helps A LOT!

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 11, 2014

@doutriaux1 Closing this issue now.

@doutriaux1 doutriaux1 removed their assignment Aug 28, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 28, 2014

@aashish24 based on your description above
add_cdat_package_dependent(Cython "" "" OFF "CDAT_BUILD_LEAN" OFF)
would mean cython is never built. But it is built. I still don't understand your magic

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 28, 2014

I think o got it. It's on because of dependencies

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 28, 2014

in devel @aashish24 please review issue_544_build_all_not_building_all

@doutriaux1 doutriaux1 closed this Sep 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment