New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boxfill does NOT show all data #555

Closed
doutriaux1 opened this Issue Aug 13, 2014 · 8 comments

Comments

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Aug 13, 2014

following code:

s= numpy.sin(numpy.arange(100))
s=numpy.reshape(s,(10,10))
x=vcs.init()
x.plot(s)

only shows 9x9 matrix
infinity

@doutriaux1 doutriaux1 added bug labels Aug 13, 2014

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Aug 13, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 13, 2014

@aashish24 @jbeezley I will probably need your help for generating correct vtk grid

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 13, 2014

Sure. but I think its right. You are creating a grid with 10 points and hence 9 cells. If you want to change that, then we would have to treat each point as the cell center.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 13, 2014

exactly that's what we need to do. I was trying to explain this earlier. I think all I need to do is use lon.getBounds(), lat.getBounds() instead of lon/lat. Should be fairly straight forward.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 13, 2014

No that is a different thing. Where to use the grid point as cell or points is at root level of how we treat the data. That not just drives the visualization but also the filtering. The bounds you were mentioning earlier may just treat it at the plot level but then the filter will be broken. We need to look at it carefully. How does old VCS treated a array of 10*10?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 13, 2014

vcs always used bounds to generate "cells" see attached plot using 1.5.1 bellow.
crunchy

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 13, 2014

so yes we have 10x10 points, but when defining the grid we need to define the "Cells" correclty (using bounds on axes). Boxfill is already using "cell" to plot if I remember correctly.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 13, 2014

If that's the case, we would have tell VTK that 10X10 are cells and not points. Where is the code in VTKPlots.py?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 13, 2014

@aashish24 let's gotomeeting there's a lot of little tweaks I need your help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment