New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animations now need PyQt4 old code seems broken #579

Closed
doutriaux1 opened this Issue Aug 28, 2014 · 16 comments

Comments

Projects
None yet
5 participants
@doutriaux1
Member

doutriaux1 commented Aug 28, 2014

newer animation seem to be inheriting from animate_obj_old why not animate_obj?
test file I used to have broken:
doutriaux1@maryam:[vcs]:[master*]:[1313]> python Test/test_basic_animation.py
Adding VCS element: 3d_vector default
Adding VCS element: 3d_scalar default
FOR NOW STILL READING IN OLD WAY
FOR NOW STILL READING IN OLD WAY
/lgm/uvcdat/2014-08-27-devel-default/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/Canvas.py:5317: UserWarning: need to implement code to redraw vcs after colormap change
warnings.warn("need to implement code to redraw vcs after colormap change")
/lgm/uvcdat/2014-08-27-devel-default/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/Canvas.py:3667: UserWarning: VCS Behaviour changed, in order to interact with window, start the interaction mode with:
x.interact()
warnings.warn("VCS Behaviour changed, in order to interact with window, start the interaction mode with:\n x.interact()")
Traceback (most recent call last):
File "Test/test_basic_animation.py", line 37, in
x.animate.create(thread_it=True)
TypeError: create() got an unexpected keyword argument 'thread_it'

begining of a branch to implemetn conditional PyQt in place

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Aug 28, 2014

@doutriaux1 doutriaux1 added VCS labels Aug 28, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 28, 2014

branch is:
issue_579_anim_needs_Qt_test_cmd_line_broken

I used to have a basic anim class that worked from command line and was Qt-free.

Qt connection are only needed from within vistrails. All Qt needing class should be implemented inside vistrails repo and on top of QT-less classes.

@dakoop

This comment has been minimized.

Contributor

dakoop commented Aug 29, 2014

I used animate_old_obj because I believe that is how the original GUI animation worked, and I was unaware of the Qt-less options for animation (the requirements in #490 were rather vague). I'll take a look given this info.

@dakoop

This comment has been minimized.

Contributor

dakoop commented Sep 1, 2014

Pushed uvcdat-579-fix-animate-signals to vistrails repo and bugfix-579-fix-animate-signals to the uvcdat repo. Please merge both at the same time.

@durack1

This comment has been minimized.

Member

durack1 commented Sep 3, 2014

It seems that loading the VCS module requires this in the latest devel https://github.com/UV-CDAT/uvcdat-devel/commit/7f57ca0c92a251de86628dd444034fa880eaac52:

public1:/home/p1d> which python
/home/p1d/140902_metrics/PCMDI_METRICS/bin/python
public1:/home/p1d> python
Python 2.7.7 (default, Sep  2 2014, 19:33:41)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import vcs
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/p1d/140902_metrics/PCMDI_METRICS/lib/python2.7/site-packages/vcs/__init__.py", line 30, in <module>
    from utils import *
  File "/home/p1d/140902_metrics/PCMDI_METRICS/lib/python2.7/site-packages/vcs/utils.py", line 6, in <module>
    import boxfill
  File "/home/p1d/140902_metrics/PCMDI_METRICS/lib/python2.7/site-packages/vcs/boxfill.py", line 30, in <module>
    import Canvas
  File "/home/p1d/140902_metrics/PCMDI_METRICS/lib/python2.7/site-packages/vcs/Canvas.py", line 44, in <module>
    from VTKPlots import VTKVCSBackend
  File "/home/p1d/140902_metrics/PCMDI_METRICS/lib/python2.7/site-packages/vcs/VTKPlots.py", line 1, in <module>
    import animate_helper
  File "/home/p1d/140902_metrics/PCMDI_METRICS/lib/python2.7/site-packages/vcs/animate_helper.py", line 8, in <module>
    from PyQt4 import QtCore
ImportError: No module named PyQt4
>>>
@dakoop

This comment has been minimized.

Contributor

dakoop commented Sep 3, 2014

@durack1, I did not merge into devel/master because the changes should be synced with the changes to the vistrails repo. I do not believe either branch referenced above has been merged yet.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 3, 2014

@dakoop there is merge conflicts (easy to fix) when merging. I asked about this yesterday it looks like @remram44 changes are in uvcdat-master but not uvcdat-next. @remram44 can you please confirm which branch(es) should be in uvcdat-next. Thanks.

@remram44

This comment has been minimized.

Contributor

remram44 commented Sep 3, 2014

The only thing I can see right now is uvcdat-520-fix-loaded-pkgs which is in uvcdat-master but not uvcdat-next.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 3, 2014

@remram44 I just saw your other post, merging that branch in. Thx!

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 3, 2014

@remram44 can you repush that branch, all I see on the repo are:

  • [new branch] uvcdat-520-fix-dependencies -> origin/uvcdat-520-fix-dependencies
  • [new branch] uvcdat-520-suppress-gui-errors -> origin/uvcdat-520-suppress-gui-errors
@remram44

This comment has been minimized.

Contributor

remram44 commented Sep 3, 2014

Alright, pushed it again

 * [new branch]      cd718f48d90a821c24869c51cc810adb0186f9ef -> uvcdat-520-fix-loaded-pkgs
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 3, 2014

uvcdat-520-fix-loaded-pkgs and origin/uvcdat-520-suppress-gui-errors should be in master.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 3, 2014

and and in uvcdat-next

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 3, 2014

@remram44 therey are both in uvcdat-next, but why is the following code still in uvcdat-next?

# BAB only load certain packages if requirements are met
        pkgs = [
            'uvcdat',
            'uvcdat_cdms'
        ]

        from packages.ParaView import package_requirements as paraview_requirements
        try:
            paraview_requirements()
            pkgs.append('ParaView')
            pkgs.append('pvclimate')
            pkgs.append('vtk')
#            pkgs.append('vtDV3D')
            pkgs.append('vis_analytics')
            pkgs.append('scikit_learn')
        except Exception:
            pass

        from packages.VisIt.info import package_requirements as visit_requirements
        try:
            visit_requirements()
            pkgs.append('VisIt')
        except Exception:
            pass

#        self.vistrailsStartup.set_needed_packages(pkgs)
        self.vistrailsStartup.init()

        #uv-cdat plots initialization
        self.initialize_uvcdat_plots()
@remram44

This comment has been minimized.

Contributor

remram44 commented Sep 3, 2014

Merge c2a2be25 (uvcdat-520-fix-loaded-pkgs into uvcdat-next) is bad, that's why it's still in.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

pushed branches in uvcdat-master and uvcdat.git/master

@doutriaux1 doutriaux1 closed this Sep 4, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

test suite still works by the way after this merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment